From patchwork Wed Oct 10 15:03:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greta Yorsh X-Patchwork-Id: 190668 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 1AC822C008A for ; Thu, 11 Oct 2012 02:03:49 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1350486230; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=haWwbeyfr8w5swfh9MHJ/gCooqY=; b=JZZsBh7CnY+I78l zzjvzaq2OILGmoJwVSDDOpy4buBapWrshXTomsIwCCTcvu59MO3/7We8Qj4AhqjV GxilYwXFcku+rZyn2RhLgJjJlmm7t2dmgqcN6bpPDj627kQ0FZrWmzfwITddRbPV wK12ydVy3M8blYIlsjElFDh5fR9g= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:X-MC-Unique:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=pjT1wdr9RzkBK0W35NFan2fw4HmjERBd/p8AjJBr0vG2G10xLg3lB+1KhfJJUe jxJx4mov4CYmDoMSYGE+OMcZQaeV/O7lm8NTCfM/67H9Xy3nyQQ4zMXqdNjqY9Gm PrLFru72Er+vIAkSFFOupHvc3QvMY3VR+fXkYo97Ja0aY=; Received: (qmail 14967 invoked by alias); 10 Oct 2012 15:03:41 -0000 Received: (qmail 14952 invoked by uid 22791); 10 Oct 2012 15:03:38 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_SPAMHAUS_DROP, KHOP_THREADED, MSGID_MULTIPLE_AT, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Oct 2012 15:03:30 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 10 Oct 2012 16:03:28 +0100 Received: from e103227vm ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Wed, 10 Oct 2012 16:03:28 +0100 From: "Greta Yorsh" To: "Greta Yorsh" , "GCC Patches" Cc: "Ramana Radhakrishnan" , "Richard Earnshaw" , , References: <001601cda6f6$2b3fcea0$81bf6be0$@yorsh@arm.com> In-Reply-To: <001601cda6f6$2b3fcea0$81bf6be0$@yorsh@arm.com> Subject: [PATCH, ARM][2/4] Prologue using STRD in Thumb mode Date: Wed, 10 Oct 2012 16:03:24 +0100 Message-ID: <001b01cda6f8$65c98be0$315ca3a0$@yorsh@arm.com> MIME-Version: 1.0 X-MC-Unique: 112101016032804601 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Generate prologue using STRD when prefer_ldrd_strd is set in tune_params. ChangeLog gcc/ 2012-09-13 Sameera Deshpande Greta Yorsh * config/arm/arm.c (thumb2_emit_strd_push): New function. (arm_expand_prologue): Use the new function. diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index b3a3774..1212a93 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -15737,6 +15737,126 @@ arm_output_function_epilogue (FILE *file ATTRIBUTE_UNUSED, } } +/* Generate and emit a pattern that will be recognized as STRD pattern. If even + number of registers are being pushed, multiple STRD patterns are created for + all register pairs. If odd number of registers are pushed, emit a + combination of STRDs and STR for the prologue saves. */ +static void +thumb2_emit_strd_push (unsigned long saved_regs_mask) +{ + int num_regs = 0; + int i, j; + rtx par = NULL_RTX; + rtx insn = NULL_RTX; + rtx dwarf = NULL_RTX; + rtx tmp, reg, tmp1; + + for (i = 0; i <= LAST_ARM_REGNUM; i++) + if (saved_regs_mask & (1 << i)) + num_regs++; + + gcc_assert (num_regs && num_regs <= 16); + + /* Pre-decrement the stack pointer, based on there being num_regs 4-byte + registers to push. */ + tmp = gen_rtx_SET (VOIDmode, + stack_pointer_rtx, + plus_constant (Pmode, stack_pointer_rtx, -4 * num_regs)); + RTX_FRAME_RELATED_P (tmp) = 1; + insn = emit_insn (tmp); + + /* Create sequence for DWARF info. */ + dwarf = gen_rtx_SEQUENCE (VOIDmode, rtvec_alloc (num_regs + 1)); + + /* RTLs cannot be shared, hence create new copy for dwarf. */ + tmp1 = gen_rtx_SET (VOIDmode, + stack_pointer_rtx, + plus_constant (Pmode, stack_pointer_rtx, -4 * num_regs)); + RTX_FRAME_RELATED_P (tmp1) = 1; + XVECEXP (dwarf, 0, 0) = tmp1; + + /* Var j iterates over all the registers to gather all the registers in + saved_regs_mask. Var i gives index of register R_j in stack frame. + A PARALLEL RTX of register-pair is created here, so that pattern for + STRD can be matched. If num_regs is odd, 1st register will be pushed + using STR and remaining registers will be pushed with STRD in pairs. + If num_regs is even, all registers are pushed with STRD in pairs. + Hence, skip first element for odd num_regs. */ + for (i = num_regs - 1, j = LAST_ARM_REGNUM; i >= (num_regs % 2); j--) + if (saved_regs_mask & (1 << j)) + { + gcc_assert (j != SP_REGNUM); + gcc_assert (j != PC_REGNUM); + + /* Create RTX for store. New RTX is created for dwarf as + they are not sharable. */ + reg = gen_rtx_REG (SImode, j); + tmp = gen_rtx_SET (SImode, + gen_frame_mem + (SImode, + plus_constant (Pmode, stack_pointer_rtx, 4 * i)), + reg); + + tmp1 = gen_rtx_SET (SImode, + gen_frame_mem + (SImode, + plus_constant (Pmode, stack_pointer_rtx, 4 * i)), + reg); + RTX_FRAME_RELATED_P (tmp) = 1; + RTX_FRAME_RELATED_P (tmp1) = 1; + + if (((i - (num_regs % 2)) % 2) == 1) + /* When (i - (num_regs % 2)) is odd, the RTX to be emitted is yet to + be created. Hence create it first. The STRD pattern we are + generating is : + [ (SET (MEM (PLUS (SP) (NUM))) (reg_t1)) + (SET (MEM (PLUS (SP) (NUM + 4))) (reg_t2)) ] + were target registers need not be consecutive. */ + par = gen_rtx_PARALLEL (VOIDmode, rtvec_alloc (2)); + + /* Register R_j is added in PARALLEL RTX. If (i - (num_regs % 2)) is + even, the reg_j is added as 0th element and if it is odd, reg_i is + added as 1st element of STRD pattern shown above. */ + XVECEXP (par, 0, ((i - (num_regs % 2)) % 2)) = tmp; + XVECEXP (dwarf, 0, (i + 1)) = tmp1; + + if (((i - (num_regs % 2)) % 2) == 0) + /* When (i - (num_regs % 2)) is even, RTXs for both the registers + to be loaded are generated in above given STRD pattern, and the + pattern can be emitted now. */ + emit_insn (par); + + i--; + } + + if ((num_regs % 2) == 1) + { + /* If odd number of registers are pushed, generate STR pattern to store + lone register. */ + for (; (saved_regs_mask & (1 << j)) == 0; j--); + + tmp1 = gen_frame_mem (SImode, plus_constant (Pmode, + stack_pointer_rtx, 4 * i)); + reg = gen_rtx_REG (SImode, j); + tmp = gen_rtx_SET (SImode, tmp1, reg); + RTX_FRAME_RELATED_P (tmp) = 1; + + emit_insn (tmp); + + tmp1 = gen_rtx_SET (SImode, + gen_frame_mem + (SImode, + plus_constant (Pmode, stack_pointer_rtx, 4 * i)), + reg); + RTX_FRAME_RELATED_P (tmp1) = 1; + XVECEXP (dwarf, 0, (i + 1)) = tmp1; + } + + add_reg_note (insn, REG_FRAME_RELATED_EXPR, dwarf); + RTX_FRAME_RELATED_P (insn) = 1; + return; +} + /* Generate and emit an insn that we will recognize as a push_multi. Unfortunately, since this insn does not reflect very well the actual semantics of the operation, we need to annotate the insn for the benefit @@ -16661,8 +16781,25 @@ arm_expand_prologue (void) saved_regs += frame; } } - insn = emit_multi_reg_push (live_regs_mask); - RTX_FRAME_RELATED_P (insn) = 1; + + if (current_tune->prefer_ldrd_strd + && !optimize_function_for_size_p (cfun)) + { + if (TARGET_THUMB2) + { + thumb2_emit_strd_push (live_regs_mask); + } + else + { + insn = emit_multi_reg_push (live_regs_mask); + RTX_FRAME_RELATED_P (insn) = 1; + } + } + else + { + insn = emit_multi_reg_push (live_regs_mask); + RTX_FRAME_RELATED_P (insn) = 1; + } } if (! IS_VOLATILE (func_type))