Patchwork [PULL,for,Luiz,00/25] Combined qemu-sockets cleanup v2 + NBD server

login
register
mail settings
Submitter Paolo Bonzini
Date Oct. 10, 2012, 2:02 p.m.
Message ID <1349877786-23514-1-git-send-email-pbonzini@redhat.com>
Download mbox
Permalink /patch/190644/
State New
Headers show

Pull-request

git://github.com/bonzini/qemu.git nbd-next

Comments

Paolo Bonzini - Oct. 10, 2012, 2:02 p.m.
Luiz,

The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade:

  ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000)

are available in the git repository at:

  git://github.com/bonzini/qemu.git nbd-next

for you to fetch changes up to 7a057978b8b8f7578c03a470ffd8c486a778497a:

  hmp: add NBD server commands (2012-10-10 13:44:09 +0200)


The following patches changed from v1:

04/25 qemu-sockets: add nonblocking connect for Unix sockets
        v1->v2: fixed connect_state memory leaks
05/25 migration: avoid using error_is_set and thus relying on errp != NULL
        v1->v2: changed summary line of the commit message
08/25 migration (outgoing): add error propagation for all protocols
        v1->v2: turn bizarre DPRINTF into an assertion failure or just
        drop it for the failure test of O_NONBLOCK. Clean up after this
        change.
13/25 vnc: add error propagation to vnc_display_open
        v1->v2: small cleanup for the if(reverse) case, do not use
        qerror_report_err.


The following patches are unreviewed:

07/25 migration: use qemu-sockets to establish Unix sockets
17/25 qemu-sockets: add error propagation to inet_parse


Plus 11/25 is not reviewed, but that's NBD so it's my own turf. :)

Paolo

Paolo Bonzini (25):
      error: add error_set_errno and error_setg_errno
      qemu-sockets: add Error ** to all functions
      qemu-sockets: unix_listen and unix_connect are portable
      qemu-sockets: add nonblocking connect for Unix sockets
      migration: avoid using error_is_set and thus relying on errp != NULL
      migration: centralize call to migrate_fd_error()
      migration: use qemu-sockets to establish Unix sockets
      migration (outgoing): add error propagation for all protocols
      migration (incoming): add error propagation to fd and exec protocols
      qemu-char: ask and print error information from qemu-sockets
      nbd: ask and print error information from qemu-sockets
      qemu-ga: ask and print error information from qemu-sockets
      vnc: add error propagation to vnc_display_open
      qemu-sockets: include strerror or gai_strerror output in error messages
      qemu-sockets: add error propagation to inet_connect_addr
      qemu-sockets: add error propagation to inet_dgram_opts
      qemu-sockets: add error propagation to inet_parse
      qemu-sockets: add error propagation to Unix socket functions
      build: add QAPI files to the tools
      qapi: add socket address types
      qemu-sockets: return IPSocketAddress from inet_parse
      qemu-sockets: add socket_listen, socket_connect, socket_parse
      block: add close notifiers
      qmp: add NBD server commands
      hmp: add NBD server commands

 Makefile            |   2 +-
 Makefile.objs       |   9 +-
 block.c             |  19 ++-
 block.h             |   1 +
 block_int.h         |   2 +
 blockdev-nbd.c      | 119 +++++++++++++++
 console.h           |   2 +-
 error.c             |  28 ++++
 error.h             |   9 ++
 hmp-commands.hx     |  29 ++++
 hmp.c               |  55 +++++++
 hmp.h               |   2 +
 migration-exec.c    |  26 +---
 migration-fd.c      |  27 +---
 migration-tcp.c     |  19 +--
 migration-unix.c    |  95 ++----------
 migration.c         |  34 ++---
 migration.h         |  19 ++-
 nbd.c               |  39 ++++-
 qapi-schema.json    |  96 ++++++++++++
 qemu-char.c         |  24 ++-
 qemu-sockets.c      | 422 ++++++++++++++++++++++++++++++++++------------------
 qemu-tool.c         |   6 +
 qemu_socket.h       |  19 ++-
 qga/channel-posix.c |   8 +-
 qmp-commands.hx     |  16 ++
 qmp.c               |   6 +-
 ui/vnc.c            |  91 ++++++-----
 vl.c                |  25 ++--
 29 file modificati, 842 inserzioni(+), 407 rimozioni(-)
 create mode 100644 blockdev-nbd.c
Luiz Capitulino - Oct. 16, 2012, 1:09 p.m.
On Wed, 10 Oct 2012 16:02:41 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Luiz,
> 
> The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade:
> 
>   ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000)
> 
> are available in the git repository at:
> 
>   git://github.com/bonzini/qemu.git nbd-next
> 
> for you to fetch changes up to 7a057978b8b8f7578c03a470ffd8c486a778497a:
> 
>   hmp: add NBD server commands (2012-10-10 13:44:09 +0200)

I've applied all these patches to the qmp tree, ie. I didn't pull. I did this
because it was easier to me and because of the following changes:

 1. I've added my signed-off to all patches
 2. I've dropped previous acked & reviewed-by from me (my signed-off should
    replace those)
 3. I've dropped duplicated reviewed-by/signed-off-by from you
Paolo Bonzini - Oct. 16, 2012, 1:10 p.m.
Il 16/10/2012 15:09, Luiz Capitulino ha scritto:
> I've applied all these patches to the qmp tree, ie. I didn't pull. I did this
> because it was easier to me and because of the following changes:
> 
>  1. I've added my signed-off to all patches
>  2. I've dropped previous acked & reviewed-by from me (my signed-off should
>     replace those)
>  3. I've dropped duplicated reviewed-by/signed-off-by from you
> 

Great!  (The PULL was just for convenience in case it helped you).

Paolo
Markus Armbruster - Oct. 17, 2012, 5:02 p.m.
Paolo Bonzini <pbonzini@redhat.com> writes:

> Luiz,
>
> The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade:
>
>   ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000)
>
> are available in the git repository at:
>
>   git://github.com/bonzini/qemu.git nbd-next
>
> for you to fetch changes up to 7a057978b8b8f7578c03a470ffd8c486a778497a:
>
>   hmp: add NBD server commands (2012-10-10 13:44:09 +0200)

Reviewed up to 21/25, out of steam for today.

Paolo, you did a huge chunk of dirty work; thank you so much!