Patchwork libbacktrace patch committed: Trace through shared libraries

login
register
mail settings
Submitter Hans-Peter Nilsson
Date Oct. 10, 2012, 12:56 p.m.
Message ID <alpine.BSF.2.00.1210100853260.95024@dair.pair.com>
Download mbox | patch
Permalink /patch/190633/
State New
Headers show

Comments

Hans-Peter Nilsson - Oct. 10, 2012, 12:56 p.m.
On Tue, 9 Oct 2012, Ian Lance Taylor wrote:
> It's an incorrect warning from an old version of GCC.  Fixed like so.
> Bootstrapped and ran libbacktrace testsuite on
> x86_64-unknown-linux-gnu.  Committed to mainline.

Another two in libbackend/elf.c, committed as obvious after
build passed the point-of-failure.

	* elf.c (elf_add_syminfo_data): Add casts to avoid warning.


brgds, H-P

Patch

Index: libbacktrace/elf.c
===================================================================
--- libbacktrace/elf.c	(revision 192306)
+++ libbacktrace/elf.c	(working copy)
@@ -410,7 +410,7 @@  elf_add_syminfo_data (struct backtrace_s
     {
       struct elf_syminfo_data **pp;

-      for (pp = (struct elf_syminfo_data **) &state->syminfo_data;
+      for (pp = (struct elf_syminfo_data **) (void *) &state->syminfo_data;
 	   *pp != NULL;
 	   pp = &(*pp)->next)
 	;
@@ -422,7 +422,7 @@  elf_add_syminfo_data (struct backtrace_s
 	{
 	  struct elf_syminfo_data **pp;

-	  pp = (struct elf_syminfo_data **) &state->syminfo_data;
+	  pp = (struct elf_syminfo_data **) (void *) &state->syminfo_data;

 	  while (1)
 	    {