Patchwork ARM: dts: mxs: add the "clock-names" for gpmi-nand

login
register
mail settings
Submitter Huang Shijie
Date Oct. 10, 2012, 10:27 a.m.
Message ID <1349864829-19565-1-git-send-email-b32955@freescale.com>
Download mbox | patch
Permalink /patch/190611/
State Not Applicable
Headers show

Comments

Huang Shijie - Oct. 10, 2012, 10:27 a.m.
The current DT nodes for mx23/mx28 miss the `clocks-names` item for gpmi-nand.
So the gpmi-nand driver could not find the proper clock.

This patch fixes this issue.

Signed-off-by: Huang Shijie <b32955@freescale.com>
---
 arch/arm/boot/dts/imx23.dtsi |    1 +
 arch/arm/boot/dts/imx28.dtsi |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
Marek Vasut - Oct. 10, 2012, 11:34 a.m.
Dear Huang Shijie,

> The current DT nodes for mx23/mx28 miss the `clocks-names` item for
> gpmi-nand. So the gpmi-nand driver could not find the proper clock.
> 
> This patch fixes this issue.
> 
> Signed-off-by: Huang Shijie <b32955@freescale.com>
[...]

Reviewed-by: Marek Vasut <marex@denx.de>

I will test later today.

Best regards,
Marek Vasut
Shawn Guo - Oct. 11, 2012, 7:49 a.m.
On Wed, Oct 10, 2012 at 06:27:09PM +0800, Huang Shijie wrote:
> The current DT nodes for mx23/mx28 miss the `clocks-names` item for gpmi-nand.
> So the gpmi-nand driver could not find the proper clock.
> 
> This patch fixes this issue.
> 
> Signed-off-by: Huang Shijie <b32955@freescale.com>

Applied, thanks.

Shawn
Shawn Guo - Oct. 25, 2012, 7:16 a.m.
Hi Arnd, Olof,

Can you please apply this fix for -rc?  Otherwise, please let me know
if you prefer to get a pull request from me.

Shawn

On Wed, Oct 10, 2012 at 06:27:09PM +0800, Huang Shijie wrote:
> The current DT nodes for mx23/mx28 miss the `clocks-names` item for gpmi-nand.
> So the gpmi-nand driver could not find the proper clock.
> 
> This patch fixes this issue.
> 
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
>  arch/arm/boot/dts/imx23.dtsi |    1 +
>  arch/arm/boot/dts/imx28.dtsi |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi
> index 9ca4ca7..6d31aa3 100644
> --- a/arch/arm/boot/dts/imx23.dtsi
> +++ b/arch/arm/boot/dts/imx23.dtsi
> @@ -69,6 +69,7 @@
>  				interrupts = <13>, <56>;
>  				interrupt-names = "gpmi-dma", "bch";
>  				clocks = <&clks 34>;
> +				clock-names = "gpmi_io";
>  				fsl,gpmi-dma-channel = <4>;
>  				status = "disabled";
>  			};
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index e16d631..55c57ea 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -85,6 +85,7 @@
>  				interrupts = <88>, <41>;
>  				interrupt-names = "gpmi-dma", "bch";
>  				clocks = <&clks 50>;
> +				clock-names = "gpmi_io";
>  				fsl,gpmi-dma-channel = <4>;
>  				status = "disabled";
>  			};
> -- 
> 1.7.0.4
> 
>
Arnd Bergmann - Oct. 25, 2012, 1:23 p.m.
On Thursday 25 October 2012, Shawn Guo wrote:
> 
> Hi Arnd, Olof,
> 
> Can you please apply this fix for -rc?  Otherwise, please let me know
> if you prefer to get a pull request from me.
> 

Applied to fixes branch, and added your Ack as well as the Review
tag from Marek.

	Arnd

Patch

diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi
index 9ca4ca7..6d31aa3 100644
--- a/arch/arm/boot/dts/imx23.dtsi
+++ b/arch/arm/boot/dts/imx23.dtsi
@@ -69,6 +69,7 @@ 
 				interrupts = <13>, <56>;
 				interrupt-names = "gpmi-dma", "bch";
 				clocks = <&clks 34>;
+				clock-names = "gpmi_io";
 				fsl,gpmi-dma-channel = <4>;
 				status = "disabled";
 			};
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index e16d631..55c57ea 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -85,6 +85,7 @@ 
 				interrupts = <88>, <41>;
 				interrupt-names = "gpmi-dma", "bch";
 				clocks = <&clks 50>;
+				clock-names = "gpmi_io";
 				fsl,gpmi-dma-channel = <4>;
 				status = "disabled";
 			};