Message ID | 1232130484-25188-3-git-send-email-dhananjay@netxen.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Dhananjay Phadke <dhananjay@netxen.com> Date: Fri, 16 Jan 2009 10:28:04 -0800 > Fixes a build error in absence of CONFIG_IPV6: > > drivers/net/netxen/netxen_nic_main.c:1189: error: implicit declaration of function 'ipv6_hdr' > drivers/net/netxen/netxen_nic_main.c:1189: error: invalid type argument of '->' > > Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> Gee, thanks for not even mentioning Ingo having reported this problem in your commit message. :-(( I've fixed this when committing. You didn't even CC: him on this patch posting, what gives? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
My bad, I copy-pasted the --to --cc list to git command line and missed out the original Sender in that email. Double apologies to Ingo, first for introducing the build error and other for fixing without credit to reporter :-(. Thanks Ingo, Dave. -Dhananjay -----Original Message----- From: David Miller [mailto:davem@davemloft.net] Sent: Friday, January 16, 2009 11:05 To: Dhananjay Phadke Cc: netdev@vger.kernel.org; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; mingo@elte.hu Subject: Re: [PATCH 2/2] netxen: include ipv6.h (fixes build failure) From: Dhananjay Phadke <dhananjay@netxen.com> Date: Fri, 16 Jan 2009 10:28:04 -0800 > Fixes a build error in absence of CONFIG_IPV6: > > drivers/net/netxen/netxen_nic_main.c:1189: error: implicit declaration of function 'ipv6_hdr' > drivers/net/netxen/netxen_nic_main.c:1189: error: invalid type argument of '->' > > Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> Gee, thanks for not even mentioning Ingo having reported this problem in your commit message. :-(( I've fixed this when committing. You didn't even CC: him on this patch posting, what gives? No virus found in this incoming message. Checked by AVG. Version: 7.5.526 / Virus Database: 270.10.6/1889 - Release Date: 1/12/2009 20:18 No virus found in this outgoing message. Checked by AVG. Version: 7.5.526 / Virus Database: 270.10.6/1889 - Release Date: 1/12/2009 20:18 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index f8e2629..d854f07 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/drivers/net/netxen/netxen_nic_main.c @@ -41,6 +41,7 @@ #include <linux/dma-mapping.h> #include <linux/if_vlan.h> #include <net/ip.h> +#include <linux/ipv6.h> MODULE_DESCRIPTION("NetXen Multi port (1/10) Gigabit Network Driver"); MODULE_LICENSE("GPL");
Fixes a build error in absence of CONFIG_IPV6: drivers/net/netxen/netxen_nic_main.c:1189: error: implicit declaration of function 'ipv6_hdr' drivers/net/netxen/netxen_nic_main.c:1189: error: invalid type argument of '->' Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic_main.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)