Patchwork autoconf/ulogd: fix broken libpcap AM_CONDITIONAL

login
register
mail settings
Submitter Gustavo Zacarias
Date Oct. 9, 2012, 7:27 p.m.
Message ID <1349810839-5958-1-git-send-email-gustavo@zacarias.com.ar>
Download mbox | patch
Permalink /patch/190419/
State Accepted
Headers show

Comments

Gustavo Zacarias - Oct. 9, 2012, 7:27 p.m.
The AM_CONDITIONAL lacks the opening bracket, hence it always evaluates
as true, even if there's no libpcap found thus causing build breakage.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Pablo Neira - Oct. 10, 2012, 9:15 a.m.
On Tue, Oct 09, 2012 at 04:27:19PM -0300, Gustavo Zacarias wrote:
> The AM_CONDITIONAL lacks the opening bracket, hence it always evaluates
> as true, even if there's no libpcap found thus causing build breakage.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/configure.ac b/configure.ac
index 10b6e1f..57c596c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -21,7 +21,7 @@  AC_SEARCH_LIBS([dlopen], [dl], [libdl_LIBS="$LIBS"; LIBS=""])
 AC_SUBST([libdl_LIBS])
 AC_SEARCH_LIBS([pcap_close], [pcap], [libpcap_LIBS="-lpcap"; LIBS=""])
 AC_SUBST([libpcap_LIBS])
-AM_CONDITIONAL([HAVE_PCAP], test -n "$libpcap_LIBS"])
+AM_CONDITIONAL([HAVE_PCAP],[test -n "$libpcap_LIBS"])
 
 dnl Checks for header files.
 AC_HEADER_DIRENT