Patchwork [RFC] mtd/uclinux: support ROM and allow passing the base address

login
register
mail settings
Submitter Greg Ungerer
Date Oct. 9, 2012, 10:37 a.m.
Message ID <5073FE55.2000402@snapgear.com>
Download mbox
Permalink /patch/190277/
State RFC
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git cfmmu

Comments

Greg Ungerer - Oct. 9, 2012, 10:37 a.m.
Hi Uwe,

On 10/09/2012 06:44 PM, Uwe Kleine-König wrote:
> On Tue, Oct 09, 2012 at 01:29:46PM +1000, Greg Ungerer wrote:
>> On 09/10/12 01:25, Uwe Kleine-K÷nig wrote:
>>> This allows to put the filesystem at a defined address in ROM allowing
>>> to save more precious RAM.
>>>
>>> I think it's save to default to ROM because the intention of using the
>>> uclinux map is to use a romfs and so mtd-ram doesn't give you anything
>>> that mtd-rom doesn't.
>>>
>>> Signed-off-by: Uwe Kleine-K├Ànig <u.kleine-koenig@pengutronix.de>
>>
>> Looks good to me, so:
>>
>> Acked-by: Greg Ungerer <gerg@uclinux.org>
>>
>> Couple of things to be aware of. Artem currently has a couple of
>> patches against this file (looks like at least 1 of them is currently
>> in linux-next). It will probably conflict with your changes, should
>> be easy enough to fix up.
> If you tell me a branch to test, I can do so.

Sure. All three patches I sent to the linux-mtd list are here:

The following changes since commit 979570e02981d4a8fc20b3cc8fd651856c98ee9d:
   Linus Torvalds (1):
         Linux 3.6-rc7

are available in the git repository at:

   git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git cfmmu

Greg Ungerer (3):
       mtd: fix wrong usage of ioremap_nocache() in uclinux.c map driver
       mtd: allow uclinux map driver to be used on any ColdFire CPU platform
       mtd: clean up uclinux.c map driver

  drivers/mtd/maps/Kconfig   |    2 +-
  drivers/mtd/maps/uclinux.c |   42 
+++++++++++++++++++-----------------------
  2 files changed, 20 insertions(+), 24 deletions(-)


As far as I can see Artem has pushed the first 2 into for linux-next,
but not the third. I am hoping he hops in here and lets us know what
his intentions are with the third...

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close,                            FAX:         +61 7 3891 3630
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
Uwe Kleine-König - Oct. 10, 2012, 7:58 a.m.
Hello,

On Tue, Oct 09, 2012 at 08:37:09PM +1000, Greg Ungerer wrote:
> On 10/09/2012 06:44 PM, Uwe Kleine-König wrote:
> >On Tue, Oct 09, 2012 at 01:29:46PM +1000, Greg Ungerer wrote:
> >>On 09/10/12 01:25, Uwe Kleine-K÷nig wrote:
> >>>This allows to put the filesystem at a defined address in ROM allowing
> >>>to save more precious RAM.
> >>>
> >>>I think it's save to default to ROM because the intention of using the
> >>>uclinux map is to use a romfs and so mtd-ram doesn't give you anything
> >>>that mtd-rom doesn't.
> >>>
> >>>Signed-off-by: Uwe Kleine-K├Ànig <u.kleine-koenig@pengutronix.de>
> >>
> >>Looks good to me, so:
> >>
> >>Acked-by: Greg Ungerer <gerg@uclinux.org>
> >>
> >>Couple of things to be aware of. Artem currently has a couple of
> >>patches against this file (looks like at least 1 of them is currently
> >>in linux-next). It will probably conflict with your changes, should
> >>be easy enough to fix up.
> >If you tell me a branch to test, I can do so.
> 
> Sure. All three patches I sent to the linux-mtd list are here:
> 
> The following changes since commit 979570e02981d4a8fc20b3cc8fd651856c98ee9d:
>   Linus Torvalds (1):
>         Linux 3.6-rc7
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git cfmmu
> 
> Greg Ungerer (3):
>       mtd: fix wrong usage of ioremap_nocache() in uclinux.c map driver
>       mtd: allow uclinux map driver to be used on any ColdFire CPU platform
>       mtd: clean up uclinux.c map driver
> 
>  drivers/mtd/maps/Kconfig   |    2 +-
>  drivers/mtd/maps/uclinux.c |   42
> +++++++++++++++++++-----------------------
>  2 files changed, 20 insertions(+), 24 deletions(-)
> 
> 
> As far as I can see Artem has pushed the first 2 into for linux-next,
> but not the third. I am hoping he hops in here and lets us know what
> his intentions are with the third...
This branch merged into my tree still works fine.

Something I noticed is that the printk cleanups could look a bit nicer
if you used

	#define pr_fmt(fmt)	"uclinux[mtd]: " fmt

and then pr_notice et al. But maybe this is only subjective.

Also I'm not sure if all the comments are still correct with my change.

(And btw, your mailer is broken regarding line breaking and non-ascii
characters.)

Best regards
Uwe
Mike Frysinger - Oct. 12, 2012, 4:46 a.m.
On Tue, Oct 9, 2012 at 6:37 AM, Greg Ungerer <gerg@snapgear.com> wrote:
> On 10/09/2012 06:44 PM, Uwe Kleine-König wrote:
>> On Tue, Oct 09, 2012 at 01:29:46PM +1000, Greg Ungerer wrote:
>>> On 09/10/12 01:25, Uwe Kleine-K÷nig wrote:
>>>> This allows to put the filesystem at a defined address in ROM allowing
>>>> to save more precious RAM.
>>>>
>>>> I think it's save to default to ROM because the intention of using the
>>>> uclinux map is to use a romfs and so mtd-ram doesn't give you anything
>>>> that mtd-rom doesn't.
>>>>
>>>> Signed-off-by: Uwe Kleine-K├Ànig <u.kleine-koenig@pengutronix.de>
>>>
>>> Looks good to me, so:
>>>
>>> Acked-by: Greg Ungerer <gerg@uclinux.org>
>>>
>>> Couple of things to be aware of. Artem currently has a couple of
>>> patches against this file (looks like at least 1 of them is currently
>>> in linux-next). It will probably conflict with your changes, should
>>> be easy enough to fix up.
>>
>> If you tell me a branch to test, I can do so.
>
> Sure. All three patches I sent to the linux-mtd list are here:
>
> The following changes since commit 979570e02981d4a8fc20b3cc8fd651856c98ee9d:
>   Linus Torvalds (1):
>         Linux 3.6-rc7
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git cfmmu
>
> Greg Ungerer (3):
>       mtd: fix wrong usage of ioremap_nocache() in uclinux.c map driver
>       mtd: allow uclinux map driver to be used on any ColdFire CPU platform
>       mtd: clean up uclinux.c map driver
>
>  drivers/mtd/maps/Kconfig   |    2 +-
>  drivers/mtd/maps/uclinux.c |   42
> +++++++++++++++++++-----------------------
>  2 files changed, 20 insertions(+), 24 deletions(-)
>
>
> As far as I can see Artem has pushed the first 2 into for linux-next,
> but not the third. I am hoping he hops in here and lets us know what
> his intentions are with the third...

so to be clear, Uwe's patch hasn't been picked up by anyone yet so we
can get it fixed first ?
-mike
Greg Ungerer - Oct. 12, 2012, 5:57 a.m.
On 12/10/12 14:46, Mike Frysinger wrote:
> On Tue, Oct 9, 2012 at 6:37 AM, Greg Ungerer <gerg@snapgear.com> wrote:
>> On 10/09/2012 06:44 PM, Uwe Kleine-K÷nig wrote:
>>> On Tue, Oct 09, 2012 at 01:29:46PM +1000, Greg Ungerer wrote:
>>>> On 09/10/12 01:25, Uwe Kleine-K├Ànig wrote:
>>>>> This allows to put the filesystem at a defined address in ROM allowing
>>>>> to save more precious RAM.
>>>>>
>>>>> I think it's save to default to ROM because the intention of using the
>>>>> uclinux map is to use a romfs and so mtd-ram doesn't give you anything
>>>>> that mtd-rom doesn't.
>>>>>
>>>>> Signed-off-by: Uwe Kleine-KÔö£├Çnig <u.kleine-koenig@pengutronix.de>
>>>>
>>>> Looks good to me, so:
>>>>
>>>> Acked-by: Greg Ungerer <gerg@uclinux.org>
>>>>
>>>> Couple of things to be aware of. Artem currently has a couple of
>>>> patches against this file (looks like at least 1 of them is currently
>>>> in linux-next). It will probably conflict with your changes, should
>>>> be easy enough to fix up.
>>>
>>> If you tell me a branch to test, I can do so.
>>
>> Sure. All three patches I sent to the linux-mtd list are here:
>>
>> The following changes since commit 979570e02981d4a8fc20b3cc8fd651856c98ee9d:
>>    Linus Torvalds (1):
>>          Linux 3.6-rc7
>>
>> are available in the git repository at:
>>
>>    git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git cfmmu
>>
>> Greg Ungerer (3):
>>        mtd: fix wrong usage of ioremap_nocache() in uclinux.c map driver
>>        mtd: allow uclinux map driver to be used on any ColdFire CPU platform
>>        mtd: clean up uclinux.c map driver
>>
>>   drivers/mtd/maps/Kconfig   |    2 +-
>>   drivers/mtd/maps/uclinux.c |   42
>> +++++++++++++++++++-----------------------
>>   2 files changed, 20 insertions(+), 24 deletions(-)
>>
>>
>> As far as I can see Artem has pushed the first 2 into for linux-next,
>> but not the third. I am hoping he hops in here and lets us know what
>> his intentions are with the third...
>
> so to be clear, Uwe's patch hasn't been picked up by anyone yet so we
> can get it fixed first ?

I haven't picked it up. I assumed Artem would, but I have not seen
any response from him on this yet.

I thought you where going to put a comment in there,
http://mailman.uclinux.org/pipermail/uclinux-dev/2012-May/051873.html

In any case, Uwe, that thread states what the issue is when it came
up a few months back.

Regards
Greg
Artem Bityutskiy - Oct. 15, 2012, 2 p.m.
On Fri, 2012-10-12 at 15:57 +1000, Greg Ungerer wrote:
> I haven't picked it up. I assumed Artem would, but I have not seen
> any response from him on this yet. 

I did not pick up anything. Also, your patches are now in Linuses tree.