Patchwork [3/3] UBUNTU: [Config] enforce USB_[EHCI|OHCI]_HCD_PLATFORM=n on arm[el|hf]

login
register
mail settings
Submitter Paolo Pisati
Date Oct. 9, 2012, 10:31 a.m.
Message ID <1349778689-12835-4-git-send-email-paolo.pisati@canonical.com>
Download mbox | patch
Permalink /patch/190263/
State New
Headers show

Comments

Paolo Pisati - Oct. 9, 2012, 10:31 a.m.
BugLink: http://bugs.launchpad.net/bugs/1061599

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 debian.master/config/enforce |    3 +++
 1 file changed, 3 insertions(+)
Andy Whitcroft - Oct. 9, 2012, 11:42 a.m.
On Tue, Oct 09, 2012 at 12:31:29PM +0200, Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/1061599
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  debian.master/config/enforce |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/debian.master/config/enforce b/debian.master/config/enforce
> index 0256c45..d57660c 100644
> --- a/debian.master/config/enforce
> +++ b/debian.master/config/enforce
> @@ -122,3 +122,6 @@ value CONFIG_I2C_DESIGNWARE_PLATFORM m | \
>  (flavour highbank &/ value CONFIG_RTC_DRV_PL031 y) | \
>  value CONFIG_RTC_DRV_PL031 m | \
>  !exists CONFIG_RTC_DRV_PL031
> +
> +# Don't use the generic ehci/ohci code on omap, it doesn't work 
> +(arch armel armhf &/ value CONFIG_USB_EHCI_HCD_PLATFORM n &/ value CONFIG_USB_OHCI_HCD_PLATFORM n)

Here we would only need the cut (/) on the first & I i believe, but we
can fix that on application.

-apw
Tim Gardner - Oct. 9, 2012, 12:51 p.m.
On 10/09/2012 04:31 AM, Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/1061599
>
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>   debian.master/config/enforce |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/debian.master/config/enforce b/debian.master/config/enforce
> index 0256c45..d57660c 100644
> --- a/debian.master/config/enforce
> +++ b/debian.master/config/enforce
> @@ -122,3 +122,6 @@ value CONFIG_I2C_DESIGNWARE_PLATFORM m | \
>   (flavour highbank &/ value CONFIG_RTC_DRV_PL031 y) | \
>   value CONFIG_RTC_DRV_PL031 m | \
>   !exists CONFIG_RTC_DRV_PL031
> +
> +# Don't use the generic ehci/ohci code on omap, it doesn't work
> +(arch armel armhf &/ value CONFIG_USB_EHCI_HCD_PLATFORM n &/ value CONFIG_USB_OHCI_HCD_PLATFORM n)
>

Does not compute.
Andy Whitcroft - Oct. 9, 2012, 1:03 p.m.
On Tue, Oct 09, 2012 at 06:51:26AM -0600, Tim Gardner wrote:
> On 10/09/2012 04:31 AM, Paolo Pisati wrote:
> >BugLink: http://bugs.launchpad.net/bugs/1061599
> >
> >Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> >---
> >  debian.master/config/enforce |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> >diff --git a/debian.master/config/enforce b/debian.master/config/enforce
> >index 0256c45..d57660c 100644
> >--- a/debian.master/config/enforce
> >+++ b/debian.master/config/enforce
> >@@ -122,3 +122,6 @@ value CONFIG_I2C_DESIGNWARE_PLATFORM m | \
> >  (flavour highbank &/ value CONFIG_RTC_DRV_PL031 y) | \
> >  value CONFIG_RTC_DRV_PL031 m | \
> >  !exists CONFIG_RTC_DRV_PL031
> >+
> >+# Don't use the generic ehci/ohci code on omap, it doesn't work
> >+(arch armel armhf &/ value CONFIG_USB_EHCI_HCD_PLATFORM n &/ value CONFIG_USB_OHCI_HCD_PLATFORM n)
> >
> 
> Does not compute.

Ok, I think what you are saying is that on omap you want to check those
two are off.  For that I think you want this:

    ((flavour omap &/ value CONFIG_USB_EHCI_HCD_PLATFORM n & value CONFIG_USB_OHCI_HCD_PLATFORM n) | \
    !exists MISSING) 

I want to be able to say "| true" at the end as otherwise we have no
opinion, but seemingly currently we do not have a true.

    check-config: /tmp/tmp.zSxxswMwzw/CONFIGS/amd64-config.flavour.generic: loading config
    check-config: /home/apw/git2/ubuntu-quantal/debian.master/config/enforce: loading checks
    check-config: 46/46 checks passed -- exit 0
    check-config: /tmp/tmp.zSxxswMwzw/CONFIGS/i386-config.flavour.generic: loading config
    check-config: /home/apw/git2/ubuntu-quantal/debian.master/config/enforce: loading checks
    check-config: 46/46 checks passed -- exit 0
    check-config: /tmp/tmp.zSxxswMwzw/CONFIGS/armel-config.flavour.omap: loading config
    check-config: /home/apw/git2/ubuntu-quantal/debian.master/config/enforce: loading checks
    check-config: FAIL: ((flavour omap &/ value CONFIG_USB_EHCI_HCD_PLATFORM n & value CONFIG_USB_OHCI_HCD_PLATFORM n) | !exists MISSING)
    check-config: 45/46 checks passed -- exit 1
    check-config: /tmp/tmp.zSxxswMwzw/CONFIGS/armhf-config.flavour.highbank: loading config
    check-config: /home/apw/git2/ubuntu-quantal/debian.master/config/enforce: loading checks
    check-config: 46/46 checks passed -- exit 0
    check-config: /tmp/tmp.zSxxswMwzw/CONFIGS/armhf-config.flavour.omap: loading config
    check-config: /home/apw/git2/ubuntu-quantal/debian.master/config/enforce: loading checks
    check-config: FAIL: ((flavour omap &/ value CONFIG_USB_EHCI_HCD_PLATFORM n & value CONFIG_USB_OHCI_HCD_PLATFORM n) | !exists MISSING)
    check-config: 45/46 checks passed -- exit 1
    check-config: /tmp/tmp.zSxxswMwzw/CONFIGS/powerpc-config.flavour.powerpc-smp: loading config
    check-config: /home/apw/git2/ubuntu-quantal/debian.master/config/enforce: loading checks
    check-config: 46/46 checks passed -- exit 0
    check-config: /tmp/tmp.zSxxswMwzw/CONFIGS/powerpc-config.flavour.powerpc64-smp: loading config
    check-config: /home/apw/git2/ubuntu-quantal/debian.master/config/enforce: loading checks
    check-config: 46/46 checks passed -- exit 0
    check-config: /tmp/tmp.zSxxswMwzw/CONFIGS/ppc64-config.flavour.powerpc64-smp: loading config
    check-config: /home/apw/git2/ubuntu-quantal/debian.master/config/enforce: loading checks
    check-config: 46/46 checks passed -- exit 0

Once this goes in I'll get a true and false added.

-apw
Tim Gardner - Oct. 9, 2012, 1:15 p.m.

Patch

diff --git a/debian.master/config/enforce b/debian.master/config/enforce
index 0256c45..d57660c 100644
--- a/debian.master/config/enforce
+++ b/debian.master/config/enforce
@@ -122,3 +122,6 @@  value CONFIG_I2C_DESIGNWARE_PLATFORM m | \
 (flavour highbank &/ value CONFIG_RTC_DRV_PL031 y) | \
 value CONFIG_RTC_DRV_PL031 m | \
 !exists CONFIG_RTC_DRV_PL031
+
+# Don't use the generic ehci/ohci code on omap, it doesn't work 
+(arch armel armhf &/ value CONFIG_USB_EHCI_HCD_PLATFORM n &/ value CONFIG_USB_OHCI_HCD_PLATFORM n)