From patchwork Tue Oct 9 07:20:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: farsync: fix support for over 30 cards Date: Mon, 08 Oct 2012 21:20:48 -0000 From: Dan Carpenter X-Patchwork-Id: 190224 Message-Id: <20121009072047.GB19159@elgon.mountain> To: Kevin Curtis Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, "David S. Miller" We're trying to fill a 64 bit bitmap but only the lower 30 shifts work because the shift wraps around. Signed-off-by: Dan Carpenter --- Static checker stuff. No one actually has over 30 of these cards... :P -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c index 1a62318..b627132 100644 --- a/drivers/net/wan/farsync.c +++ b/drivers/net/wan/farsync.c @@ -597,7 +597,7 @@ fst_q_work_item(u64 * queue, int card_index) * bottom half for the card. Note the limitation of 64 cards. * That ought to be enough */ - mask = 1 << card_index; + mask = (u64)1 << card_index; *queue |= mask; spin_unlock_irqrestore(&fst_work_q_lock, flags); }