Patchwork farsync: fix support for over 30 cards

login
register
mail settings
Submitter Dan Carpenter
Date Oct. 9, 2012, 7:20 a.m.
Message ID <20121009072047.GB19159@elgon.mountain>
Download mbox | patch
Permalink /patch/190224/
State Accepted
Delegated to: David Miller
Headers show

Comments

Dan Carpenter - Oct. 9, 2012, 7:20 a.m.
We're trying to fill a 64 bit bitmap but only the lower 30 shifts work
because the shift wraps around.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static checker stuff.  No one actually has over 30 of these cards...  :P

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 9, 2012, 5:55 p.m.
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 9 Oct 2012 10:20:48 +0300

> We're trying to fill a 64 bit bitmap but only the lower 30 shifts work
> because the shift wraps around.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kevin Curtis - July 26, 2013, 10:13 a.m.
Hi David,
    I'd like to update the FarSync driver for our T-Series cards in the latest Linux Kernel and I would also like to add a new driver for our FarSync Flex USB device.

Should I direct the patch to you?


Regards


Kevin Curtis
Linux Development
FarSite Communications Ltd http://www.farsite.com
Winner of The Queen's Award for Enterprise 2009
tel:  +44 1256 330461
fax:  +44 1256 854931



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dan Carpenter - July 26, 2013, 11:41 p.m.
On Fri, Jul 26, 2013 at 11:13:25AM +0100, Kevin Curtis wrote:
> Hi David,
>     I'd like to update the FarSync driver for our T-Series cards
> in the latest Linux Kernel and I would also like to add a new
> driver for our FarSync Flex USB device.
> 
> Should I direct the patch to you?
> 

Read Documentation/SubmittingPatches
Use ./scripts/get_maintainer.pl to find who needs to be CC'd.

If you want, you can send your first attempt to kernel-janitors
without CC'ing Dave and netdev and we will tell you which bits of
SubmittingPatches you have missed.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
govindarajulu.v - July 27, 2013, 8:27 p.m.
On 07/27/2013 05:11 AM, Dan Carpenter wrote:
> On Fri, Jul 26, 2013 at 11:13:25AM +0100, Kevin Curtis wrote:
>> Hi David,
>>      I'd like to update the FarSync driver for our T-Series cards
>> in the latest Linux Kernel and I would also like to add a new
>> driver for our FarSync Flex USB device.
>>
>> Should I direct the patch to you?
>>
>
> Read Documentation/SubmittingPatches
> Use ./scripts/get_maintainer.pl to find who needs to be CC'd.

you can also go through

Write and Submit your first Linux kernel Patch - Greg KH 
https://www.youtube.com/watch?v=LLBrBBImJt4
Why I dont want your code - Greg KH https://www.youtube.com/watch?v=fMeH7wqOwXA

helped me a lot.

//govind
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
index 1a62318..b627132 100644
--- a/drivers/net/wan/farsync.c
+++ b/drivers/net/wan/farsync.c
@@ -597,7 +597,7 @@  fst_q_work_item(u64 * queue, int card_index)
 	 * bottom half for the card.  Note the limitation of 64 cards.
 	 * That ought to be enough
 	 */
-	mask = 1 << card_index;
+	mask = (u64)1 << card_index;
 	*queue |= mask;
 	spin_unlock_irqrestore(&fst_work_q_lock, flags);
 }