Patchwork [U-Boot] arm: trats: Power down core 1

login
register
mail settings
Submitter Piotr Wilczek
Date Oct. 9, 2012, 6:45 a.m.
Message ID <1349765142-27872-2-git-send-email-p.wilczek@samsung.com>
Download mbox | patch
Permalink /patch/190222/
State Accepted
Delegated to: Minkyu Kang
Headers show

Comments

Piotr Wilczek - Oct. 9, 2012, 6:45 a.m.
This patch turns power down for unused core 1

Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
CC: Minkyu Kang <mk7.kang@samsung.com>
---
 board/samsung/trats/trats.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Albert ARIBAUD - Oct. 9, 2012, 5:06 p.m.
Hi Piotr,

On Tue, 09 Oct 2012 08:45:42 +0200, Piotr Wilczek
<p.wilczek@samsung.com> wrote:

> This patch turns power down for unused core 1
> 
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  board/samsung/trats/trats.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
> index 57400ce..d5c681c 100644
> --- a/board/samsung/trats/trats.c
> +++ b/board/samsung/trats/trats.c
> @@ -321,6 +321,10 @@ static void board_power_init(void)
>  	writel(0, (unsigned int)&pwr->lcd1_configuration);
>  	writel(0, (unsigned int)&pwr->gps_configuration);
>  	writel(0, (unsigned int)&pwr->gps_alive_configuration);
> +
> +	/* It is necessary to power down core 1 */
> +	/* to successfully boot CPU1 in kernel */
> +	writel(0, (unsigned int)&pwr->arm_core1_configuration);
>  }
>  
>  static void board_uart_init(void)

Cc:ing trats maintainer.

Amicalement,
Kyungmin Park - Oct. 10, 2012, 1:30 a.m.
FYI: Piotr and Lukasz are working together for samsung board.

Minkyu, can you pick up this patch?

Thank you,
Kyungmin Park

> -----Original Message-----
> From: Albert ARIBAUD [mailto:albert.u.boot@aribaud.net]
> Sent: Wednesday, October 10, 2012 2:07 AM
> To: Piotr Wilczek
> Cc: u-boot@lists.denx.de; Kyungmin Park; Lukasz Majewski
> Subject: Re: [U-Boot] [PATCH] arm: trats: Power down core 1
> 
> Hi Piotr,
> 
> On Tue, 09 Oct 2012 08:45:42 +0200, Piotr Wilczek <p.wilczek@samsung.com>
> wrote:
> 
> > This patch turns power down for unused core 1
> >
> > Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > CC: Minkyu Kang <mk7.kang@samsung.com>
> > ---
> >  board/samsung/trats/trats.c |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
> > index 57400ce..d5c681c 100644
> > --- a/board/samsung/trats/trats.c
> > +++ b/board/samsung/trats/trats.c
> > @@ -321,6 +321,10 @@ static void board_power_init(void)
> >  	writel(0, (unsigned int)&pwr->lcd1_configuration);
> >  	writel(0, (unsigned int)&pwr->gps_configuration);
> >  	writel(0, (unsigned int)&pwr->gps_alive_configuration);
> > +
> > +	/* It is necessary to power down core 1 */
> > +	/* to successfully boot CPU1 in kernel */
> > +	writel(0, (unsigned int)&pwr->arm_core1_configuration);
> >  }
> >
> >  static void board_uart_init(void)
> 
> Cc:ing trats maintainer.
> 
> Amicalement,
> --
> Albert.
Minkyu Kang - Oct. 10, 2012, 9:56 a.m.
Dear Piotr Wilczek,

On 9 October 2012 15:45, Piotr Wilczek <p.wilczek@samsung.com> wrote:
> This patch turns power down for unused core 1
>
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  board/samsung/trats/trats.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>

applied to u-boot-samsung.

Thanks.
Minkyu Kang.

Patch

diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
index 57400ce..d5c681c 100644
--- a/board/samsung/trats/trats.c
+++ b/board/samsung/trats/trats.c
@@ -321,6 +321,10 @@  static void board_power_init(void)
 	writel(0, (unsigned int)&pwr->lcd1_configuration);
 	writel(0, (unsigned int)&pwr->gps_configuration);
 	writel(0, (unsigned int)&pwr->gps_alive_configuration);
+
+	/* It is necessary to power down core 1 */
+	/* to successfully boot CPU1 in kernel */
+	writel(0, (unsigned int)&pwr->arm_core1_configuration);
 }
 
 static void board_uart_init(void)