Patchwork ubi: use list_move_tail instead of list_del/list_add_tail

login
register
mail settings
Submitter Wei Yongjun
Date Oct. 9, 2012, 6:14 a.m.
Message ID <CAPgLHd_AHHe7=H18K54LvbiS0M7_w1vTMOxwwxgVdRaiXNN-OA@mail.gmail.com>
Download mbox | patch
Permalink /patch/190220/
State New
Headers show

Comments

Wei Yongjun - Oct. 9, 2012, 6:14 a.m.
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Using list_move_tail() instead of list_del() + list_add_tail().

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/mtd/ubi/fastmap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Richard Weinberger - Oct. 9, 2012, 2:18 p.m.
Am Tue, 9 Oct 2012 14:14:21 +0800
schrieb Wei Yongjun <weiyj.lk@gmail.com>:

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Using list_move_tail() instead of list_del() + list_add_tail().
> 
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard
Artem Bityutskiy - Oct. 15, 2012, 3:15 p.m.
On Tue, 2012-10-09 at 14:14 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Using list_move_tail() instead of list_del() + list_add_tail().
> 
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Pushed to linux-ubi.git, thanks!

Patch

diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index 1a5f53c..5f540c5 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -815,8 +815,7 @@  static int ubi_attach_fastmap(struct ubi_device *ubi,
 		ai->max_sqnum = max_sqnum;
 
 	list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &free, u.list) {
-		list_del(&tmp_aeb->u.list);
-		list_add_tail(&tmp_aeb->u.list, &ai->free);
+		list_move_tail(&tmp_aeb->u.list, &ai->free);
 	}
 
 	/*