From patchwork Tue Oct 9 05:48:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: ext3: fix return values on parse_options() failure Date: Mon, 08 Oct 2012 19:48:47 -0000 From: Zhao Hongjiang X-Patchwork-Id: 190213 Message-Id: <5073BABF.8090206@gmail.com> To: jack@suse.cz Cc: akpm@linux-foundation.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, "Eric W. Biederman" , serge.hallyn@canonical.com, containers@lists.linux-foundation.org From: Zhao Hongjiang parse_options() in ext3 should return 0 when parse the mount options fails. Signed-off-by: Zhao Hongjiang Reviewed-by: Lukas Czerner Acked-by: "Eric W. Biederman" --- fs/ext3/super.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 17ae5c8..ebf8312 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb, uid = make_kuid(current_user_ns(), option); if (!uid_valid(uid)) { ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option); - return -1; + return 0; } sbi->s_resuid = uid; @@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb, gid = make_kgid(current_user_ns(), option); if (!gid_valid(gid)) { ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option); - return -1; + return 0; } sbi->s_resgid = gid; break;