Patchwork [v2,08/21] pci_ids: add intel 82801BA pci-to-pci bridge id and PCI_CLASS_SERIAL_SMBUS

login
register
mail settings
Submitter Jason Baron
Date Oct. 9, 2012, 3:30 a.m.
Message ID <89784244db3b5a8db417d1194a8ec0d38b1d2e74.1349749915.git.jbaron@redhat.com>
Download mbox | patch
Permalink /patch/190180/
State New
Headers show

Comments

Jason Baron - Oct. 9, 2012, 3:30 a.m.
From: Isaku Yamahata <yamahata@valinux.co.jp>

Adds pci id constants which will be used by q35.

[jbaron@redhat.com: move #define PCI_CLASS_SERIAL_SMBUS to another patch]
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: Jason Baron <jbaron@redhat.com>
---
 hw/pci_ids.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Paolo Bonzini - Oct. 9, 2012, 7:48 a.m.
Il 09/10/2012 05:30, Jason Baron ha scritto:
> From: Isaku Yamahata <yamahata@valinux.co.jp>
> 
> Adds pci id constants which will be used by q35.
> 
> [jbaron@redhat.com: move #define PCI_CLASS_SERIAL_SMBUS to another patch]
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
>  hw/pci_ids.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

No need really to keep PCI_CLASS_SERIAL_SMBUS in the subject and note it
in the commit message, IMHO.  But it doesn't really matter.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>


> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
> index 301bf1c..4017eb7 100644
> --- a/hw/pci_ids.h
> +++ b/hw/pci_ids.h
> @@ -106,6 +106,7 @@
>  #define PCI_DEVICE_ID_INTEL_82801AA_5    0x2415
>  #define PCI_DEVICE_ID_INTEL_82801D       0x24CD
>  #define PCI_DEVICE_ID_INTEL_ESB_9        0x25ab
> +#define PCI_DEVICE_ID_INTEL_82801BA_11   0x244e
>  #define PCI_DEVICE_ID_INTEL_82371SB_0    0x7000
>  #define PCI_DEVICE_ID_INTEL_82371SB_1    0x7010
>  #define PCI_DEVICE_ID_INTEL_82371SB_2    0x7020
>
Blue Swirl - Oct. 13, 2012, 8:31 a.m.
On Tue, Oct 9, 2012 at 3:30 AM, Jason Baron <jbaron@redhat.com> wrote:
> From: Isaku Yamahata <yamahata@valinux.co.jp>
>
> Adds pci id constants which will be used by q35.
>
> [jbaron@redhat.com: move #define PCI_CLASS_SERIAL_SMBUS to another patch]
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
>  hw/pci_ids.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
> index 301bf1c..4017eb7 100644
> --- a/hw/pci_ids.h
> +++ b/hw/pci_ids.h
> @@ -106,6 +106,7 @@
>  #define PCI_DEVICE_ID_INTEL_82801AA_5    0x2415
>  #define PCI_DEVICE_ID_INTEL_82801D       0x24CD
>  #define PCI_DEVICE_ID_INTEL_ESB_9        0x25ab
> +#define PCI_DEVICE_ID_INTEL_82801BA_11   0x244e

In Linux pci_ids.h the ID numbers are kept sorted, so this should be
placed between PCI_DEVICE_ID_INTEL_82801AA_5 and
PCI_DEVICE_ID_INTEL_82801D.

>  #define PCI_DEVICE_ID_INTEL_82371SB_0    0x7000
>  #define PCI_DEVICE_ID_INTEL_82371SB_1    0x7010
>  #define PCI_DEVICE_ID_INTEL_82371SB_2    0x7020
> --
> 1.7.1
>

Patch

diff --git a/hw/pci_ids.h b/hw/pci_ids.h
index 301bf1c..4017eb7 100644
--- a/hw/pci_ids.h
+++ b/hw/pci_ids.h
@@ -106,6 +106,7 @@ 
 #define PCI_DEVICE_ID_INTEL_82801AA_5    0x2415
 #define PCI_DEVICE_ID_INTEL_82801D       0x24CD
 #define PCI_DEVICE_ID_INTEL_ESB_9        0x25ab
+#define PCI_DEVICE_ID_INTEL_82801BA_11   0x244e
 #define PCI_DEVICE_ID_INTEL_82371SB_0    0x7000
 #define PCI_DEVICE_ID_INTEL_82371SB_1    0x7010
 #define PCI_DEVICE_ID_INTEL_82371SB_2    0x7020