From patchwork Mon Oct 8 23:52:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Neuling X-Patchwork-Id: 190166 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id D48322C036B for ; Tue, 9 Oct 2012 10:52:57 +1100 (EST) Received: by ozlabs.org (Postfix) id 086692C0334; Tue, 9 Oct 2012 10:52:26 +1100 (EST) Delivered-To: linuxppc-dev@ozlabs.org Received: from localhost.localdomain (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id E40FB2C0331; Tue, 9 Oct 2012 10:52:25 +1100 (EST) Received: by localhost.localdomain (Postfix, from userid 1000) id E9CFAD46CD1; Tue, 9 Oct 2012 10:52:25 +1100 (EST) Received: from neuling.org (localhost [127.0.0.1]) by localhost.localdomain (Postfix) with ESMTP id E41A4D41CBE; Tue, 9 Oct 2012 10:52:25 +1100 (EST) From: Michael Neuling To: Eric Dumazet Subject: net: fix typo in freescale/ucc_geth.c In-reply-to: <20121008173653.1d17895964980c98af59c8ea@canb.auug.org.au> References: <20121008173653.1d17895964980c98af59c8ea@canb.auug.org.au> Comments: In-reply-to Stephen Rothwell message dated "Mon, 08 Oct 2012 17:36:53 +1100." X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.3.1 Date: Tue, 09 Oct 2012 10:52:25 +1100 Message-ID: <23452.1349740345@neuling.org> Cc: Stephen Rothwell , LKML , linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org, Maxime Bizon , "David S. Miller" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" The following patch: acb600d net: remove skb recycling added dev_free_skb() to drivers/net/ethernet/freescale/ucc_geth.c This is a typo and should be dev_kfree_skb(). This fixes this. Signed-off-by: Michael Neuling --- This hit as a compile error in next-20121008 with mpc85xx_defconfig. diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index dfa0aaa..0a70bb5 100644 --- a/drivers/net/ethernet/freescale/ucc_geth.c +++ b/drivers/net/ethernet/freescale/ucc_geth.c @@ -3268,7 +3268,7 @@ static int ucc_geth_rx(struct ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit if (netif_msg_rx_err(ugeth)) ugeth_err("%s, %d: ERROR!!! skb - 0x%08x", __func__, __LINE__, (u32) skb); - dev_free_skb(skb); + dev_kfree_skb(skb); ugeth->rx_skbuff[rxQ][ugeth->skb_currx[rxQ]] = NULL; dev->stats.rx_dropped++;