From patchwork Mon Oct 8 21:55:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stephen hemminger X-Patchwork-Id: 190150 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 613AF2C01FD for ; Tue, 9 Oct 2012 08:56:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568Ab2JHV4K (ORCPT ); Mon, 8 Oct 2012 17:56:10 -0400 Received: from mail.vyatta.com ([76.74.103.46]:60374 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026Ab2JHV4J (ORCPT ); Mon, 8 Oct 2012 17:56:09 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.vyatta.com (Postfix) with ESMTP id DF1AB1410462; Mon, 8 Oct 2012 14:56:08 -0700 (PDT) X-Virus-Scanned: amavisd-new at tahiti.vyatta.com Received: from mail.vyatta.com ([127.0.0.1]) by localhost (mail.vyatta.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hr1aHMWo-aIf; Mon, 8 Oct 2012 14:56:08 -0700 (PDT) Received: from nehalam.linuxnetplumber.net (static-50-53-80-93.bvtn.or.frontiernet.net [50.53.80.93]) by mail.vyatta.com (Postfix) with ESMTPSA id 1BA021410460; Mon, 8 Oct 2012 14:56:08 -0700 (PDT) Date: Mon, 8 Oct 2012 14:55:30 -0700 From: Stephen Hemminger To: Fengguang Wu , David Miller Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] vxlan: fix more sparse warnings Message-ID: <20121008145530.54a56962@nehalam.linuxnetplumber.net> In-Reply-To: <20121007123635.GB24374@localhost> References: <20121007123635.GB24374@localhost> Organization: Vyatta X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix a couple harmless sparse warnings reported by Fengguang Wu. Signed-off-by: Stephen Hemminger --- Later patches will fix the other warnings as a side effect of more substantial changes. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/vxlan.c 2012-10-08 13:41:36.920210233 -0700 +++ b/drivers/net/vxlan.c 2012-10-08 13:44:05.630729809 -0700 @@ -1084,13 +1084,13 @@ static int vxlan_fill_info(struct sk_buf if (nla_put_u32(skb, IFLA_VXLAN_ID, vxlan->vni)) goto nla_put_failure; - if (vxlan->gaddr && nla_put_u32(skb, IFLA_VXLAN_GROUP, vxlan->gaddr)) + if (vxlan->gaddr && nla_put_be32(skb, IFLA_VXLAN_GROUP, vxlan->gaddr)) goto nla_put_failure; if (vxlan->link && nla_put_u32(skb, IFLA_VXLAN_LINK, vxlan->link)) goto nla_put_failure; - if (vxlan->saddr && nla_put_u32(skb, IFLA_VXLAN_LOCAL, vxlan->saddr)) + if (vxlan->saddr && nla_put_be32(skb, IFLA_VXLAN_LOCAL, vxlan->saddr)) goto nla_put_failure; if (nla_put_u8(skb, IFLA_VXLAN_TTL, vxlan->ttl) ||