Patchwork vxlan: fix more sparse warnings

login
register
mail settings
Submitter stephen hemminger
Date Oct. 8, 2012, 9:55 p.m.
Message ID <20121008145530.54a56962@nehalam.linuxnetplumber.net>
Download mbox | patch
Permalink /patch/190150/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Oct. 8, 2012, 9:55 p.m.
Fix a couple harmless sparse warnings reported by Fengguang Wu.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
Later patches will fix the other warnings as a side effect of more substantial
changes.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 8, 2012, 9:58 p.m.
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 8 Oct 2012 14:55:30 -0700

> Fix a couple harmless sparse warnings reported by Fengguang Wu.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Applied, thanks Stephen.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/drivers/net/vxlan.c	2012-10-08 13:41:36.920210233 -0700
+++ b/drivers/net/vxlan.c	2012-10-08 13:44:05.630729809 -0700
@@ -1084,13 +1084,13 @@  static int vxlan_fill_info(struct sk_buf
 	if (nla_put_u32(skb, IFLA_VXLAN_ID, vxlan->vni))
 		goto nla_put_failure;
 
-	if (vxlan->gaddr && nla_put_u32(skb, IFLA_VXLAN_GROUP, vxlan->gaddr))
+	if (vxlan->gaddr && nla_put_be32(skb, IFLA_VXLAN_GROUP, vxlan->gaddr))
 		goto nla_put_failure;
 
 	if (vxlan->link && nla_put_u32(skb, IFLA_VXLAN_LINK, vxlan->link))
 		goto nla_put_failure;
 
-	if (vxlan->saddr && nla_put_u32(skb, IFLA_VXLAN_LOCAL, vxlan->saddr))
+	if (vxlan->saddr && nla_put_be32(skb, IFLA_VXLAN_LOCAL, vxlan->saddr))
 		goto nla_put_failure;
 
 	if (nla_put_u8(skb, IFLA_VXLAN_TTL, vxlan->ttl) ||