Patchwork [1/3] e500: Fix serial initialization

login
register
mail settings
Submitter Bharat Bhushan
Date Oct. 8, 2012, 4:46 p.m.
Message ID <1349714816-12618-2-git-send-email-Bharat.Bhushan@freescale.com>
Download mbox | patch
Permalink /patch/190059/
State New
Headers show

Comments

Bharat Bhushan - Oct. 8, 2012, 4:46 p.m.
it was wrongly using serial_hds[0] instead of serial_hds[1]

Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>
---
 hw/ppc/e500.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Andreas Färber - Oct. 8, 2012, 5 p.m.
Am 08.10.2012 18:46, schrieb Bharat Bhushan:
> it was wrongly using serial_hds[0] instead of serial_hds[1]
> 
> Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas
Alexander Graf - Oct. 8, 2012, 6:54 p.m.
On 08.10.2012, at 18:46, Bharat Bhushan wrote:

> it was wrongly using serial_hds[0] instead of serial_hds[1]
> 
> Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>

Thanks, applied to ppc-next.

Alex

> ---
> hw/ppc/e500.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
> index d23f9b2..1949c81 100644
> --- a/hw/ppc/e500.c
> +++ b/hw/ppc/e500.c
> @@ -496,7 +496,7 @@ void ppce500_init(PPCE500Params *params)
>     if (serial_hds[1]) {
>         serial_mm_init(address_space_mem, MPC8544_SERIAL1_REGS_BASE,
>                        0, mpic[12+26], 399193,
> -                       serial_hds[0], DEVICE_BIG_ENDIAN);
> +                       serial_hds[1], DEVICE_BIG_ENDIAN);
>     }
> 
>     /* General Utility device */
> -- 
> 1.7.0.4
> 
>

Patch

diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index d23f9b2..1949c81 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -496,7 +496,7 @@  void ppce500_init(PPCE500Params *params)
     if (serial_hds[1]) {
         serial_mm_init(address_space_mem, MPC8544_SERIAL1_REGS_BASE,
                        0, mpic[12+26], 399193,
-                       serial_hds[0], DEVICE_BIG_ENDIAN);
+                       serial_hds[1], DEVICE_BIG_ENDIAN);
     }
 
     /* General Utility device */