Patchwork target-sparc: Fix optimized %icc comparisons

login
register
mail settings
Submitter Richard Henderson
Date Oct. 8, 2012, 3:42 p.m.
Message ID <1349710923-30913-1-git-send-email-rth@twiddle.net>
Download mbox | patch
Permalink /patch/190052/
State New
Headers show

Comments

Richard Henderson - Oct. 8, 2012, 3:42 p.m.
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-sparc/translate.c | 1 +
 1 file changed, 1 insertion(+)

This should fix the boot problem that Aurelien saw.  It also showed
up in some userland speed testing I'm trying to set up (cross gcc).


r~
Aurelien Jarno - Oct. 8, 2012, 5:20 p.m.
On Mon, Oct 08, 2012 at 08:42:03AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-sparc/translate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> This should fix the boot problem that Aurelien saw.  It also showed
> up in some userland speed testing I'm trying to set up (cross gcc).
> 
> 

I confirm it fixes the issue I reported.

Tested-by: Aurelien Jarno <aurelien@aurel32.net>


> diff --git a/target-sparc/translate.c b/target-sparc/translate.c
> index 472eb51..71b9d65 100644
> --- a/target-sparc/translate.c
> +++ b/target-sparc/translate.c
> @@ -1120,6 +1120,7 @@ static void gen_compare(DisasCompare *cmp, bool xcc, unsigned int cond,
>                  cmp->c2 = tcg_temp_new();
>                  tcg_gen_ext32s_tl(cmp->c1, cpu_cc_src);
>                  tcg_gen_ext32s_tl(cmp->c2, cpu_cc_src2);
> +                break;
>              }
>  #endif
>              cmp->g1 = cmp->g2 = true;
> -- 
> 1.7.11.4
> 
>

Patch

diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 472eb51..71b9d65 100644
--- a/target-sparc/translate.c
+++ b/target-sparc/translate.c
@@ -1120,6 +1120,7 @@  static void gen_compare(DisasCompare *cmp, bool xcc, unsigned int cond,
                 cmp->c2 = tcg_temp_new();
                 tcg_gen_ext32s_tl(cmp->c1, cpu_cc_src);
                 tcg_gen_ext32s_tl(cmp->c2, cpu_cc_src2);
+                break;
             }
 #endif
             cmp->g1 = cmp->g2 = true;