Patchwork [v10,14/14] target-mips-ase-dsp: Change TODO file

login
register
mail settings
Submitter Jia Liu
Date Oct. 8, 2012, 8:50 a.m.
Message ID <1349686233-26114-15-git-send-email-proljc@gmail.com>
Download mbox | patch
Permalink /patch/189950/
State New
Headers show

Comments

Jia Liu - Oct. 8, 2012, 8:50 a.m.
Delete DSP r1 & DSP r2 from TODO file.

Signed-off-by: Jia Liu <proljc@gmail.com>
---
 target-mips/TODO |    2 --
 1 file changed, 2 deletions(-)
Eric Johnson - Oct. 8, 2012, 5:11 p.m.
> -----Original Message-----

> From: qemu-devel-bounces+ericj=mips.com@nongnu.org [mailto:qemu-devel-

> bounces+ericj=mips.com@nongnu.org] On Behalf Of Jia Liu

> Sent: Monday, October 08, 2012 1:51 AM

> To: qemu-devel@nongnu.org

> Cc: aurelien@aurel32.net

> Subject: [Qemu-devel] [PATCH v10 14/14] target-mips-ase-dsp: Change TODO

> file

> 

> Delete DSP r1 & DSP r2 from TODO file.

> 

> Signed-off-by: Jia Liu <proljc@gmail.com>

> ---

>  target-mips/TODO |    2 --

>  1 file changed, 2 deletions(-)

> 

> diff --git a/target-mips/TODO b/target-mips/TODO

> index 2a3546f..15d67cd 100644

> --- a/target-mips/TODO

> +++ b/target-mips/TODO

> @@ -6,8 +6,6 @@ General

>  - Unimplemented ASEs:

>    - MDMX

>    - SmartMIPS

> -  - DSP r1

> -  - DSP r2

>  - MT ASE only partially implemented and not functional

>  - Shadow register support only partially implemented,

>    lacks set switching on interrupt/exception.

> --

> 1.7.10.2 (Apple Git-33)

> 


As I stated in a prior email, there are microMIPS instruction encodings for the DSP instructions.  Should we change this to "microMIPS DSP r1 & r2 encodings" instead of deleting?

-Eric
Aurelien Jarno - Oct. 8, 2012, 5:19 p.m.
On Mon, Oct 08, 2012 at 05:11:00PM +0000, Johnson, Eric wrote:
> > -----Original Message-----
> > From: qemu-devel-bounces+ericj=mips.com@nongnu.org [mailto:qemu-devel-
> > bounces+ericj=mips.com@nongnu.org] On Behalf Of Jia Liu
> > Sent: Monday, October 08, 2012 1:51 AM
> > To: qemu-devel@nongnu.org
> > Cc: aurelien@aurel32.net
> > Subject: [Qemu-devel] [PATCH v10 14/14] target-mips-ase-dsp: Change TODO
> > file
> > 
> > Delete DSP r1 & DSP r2 from TODO file.
> > 
> > Signed-off-by: Jia Liu <proljc@gmail.com>
> > ---
> >  target-mips/TODO |    2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/target-mips/TODO b/target-mips/TODO
> > index 2a3546f..15d67cd 100644
> > --- a/target-mips/TODO
> > +++ b/target-mips/TODO
> > @@ -6,8 +6,6 @@ General
> >  - Unimplemented ASEs:
> >    - MDMX
> >    - SmartMIPS
> > -  - DSP r1
> > -  - DSP r2
> >  - MT ASE only partially implemented and not functional
> >  - Shadow register support only partially implemented,
> >    lacks set switching on interrupt/exception.
> > --
> > 1.7.10.2 (Apple Git-33)
> > 
> 
> As I stated in a prior email, there are microMIPS instruction encodings for the DSP instructions.  Should we change this to "microMIPS DSP r1 & r2 encodings" instead of deleting?
> 

I agree, it should be changed to note that microMIPS DSP r1 & r2 are not
supported.
Jia Liu - Oct. 9, 2012, 12:02 a.m.
Hi Johnson,

On Tue, Oct 9, 2012 at 1:19 AM, aurelien@aurel32.net
<aurelien@aurel32.net> wrote:
> On Mon, Oct 08, 2012 at 05:11:00PM +0000, Johnson, Eric wrote:
>> > -----Original Message-----
>> > From: qemu-devel-bounces+ericj=mips.com@nongnu.org [mailto:qemu-devel-
>> > bounces+ericj=mips.com@nongnu.org] On Behalf Of Jia Liu
>> > Sent: Monday, October 08, 2012 1:51 AM
>> > To: qemu-devel@nongnu.org
>> > Cc: aurelien@aurel32.net
>> > Subject: [Qemu-devel] [PATCH v10 14/14] target-mips-ase-dsp: Change TODO
>> > file
>> >
>> > Delete DSP r1 & DSP r2 from TODO file.
>> >
>> > Signed-off-by: Jia Liu <proljc@gmail.com>
>> > ---
>> >  target-mips/TODO |    2 --
>> >  1 file changed, 2 deletions(-)
>> >
>> > diff --git a/target-mips/TODO b/target-mips/TODO
>> > index 2a3546f..15d67cd 100644
>> > --- a/target-mips/TODO
>> > +++ b/target-mips/TODO
>> > @@ -6,8 +6,6 @@ General
>> >  - Unimplemented ASEs:
>> >    - MDMX
>> >    - SmartMIPS
>> > -  - DSP r1
>> > -  - DSP r2
>> >  - MT ASE only partially implemented and not functional
>> >  - Shadow register support only partially implemented,
>> >    lacks set switching on interrupt/exception.
>> > --
>> > 1.7.10.2 (Apple Git-33)
>> >
>>
>> As I stated in a prior email, there are microMIPS instruction encodings for the DSP instructions.  Should we change this to "microMIPS DSP r1 & r2 encodings" instead of deleting?

Thank you very much to point this.

>>
>
> I agree, it should be changed to note that microMIPS DSP r1 & r2 are not
> supported.
>

And, I agree too :)

> --
> Aurelien Jarno                          GPG: 1024D/F1BCDB73
> aurelien@aurel32.net                 http://www.aurel32.net

Regards,
Jia.

Patch

diff --git a/target-mips/TODO b/target-mips/TODO
index 2a3546f..15d67cd 100644
--- a/target-mips/TODO
+++ b/target-mips/TODO
@@ -6,8 +6,6 @@  General
 - Unimplemented ASEs:
   - MDMX
   - SmartMIPS
-  - DSP r1
-  - DSP r2
 - MT ASE only partially implemented and not functional
 - Shadow register support only partially implemented,
   lacks set switching on interrupt/exception.