| Message ID | 50728A5E.3020102@parrot.com |
|---|---|
| State | New, archived |
| Headers | show |
Dear Grégor Boirie, > Marek, > > Sorry about that. I didn't really mean to submit an official patch at > first... No no, nothing to be sorry about actually, we're really grateful you spotted the issue and reported it! > Nevermind, please find one just below. Actually, can you try one more time and after commiting the change to your local git tree, do "git send-email --to="linux-mtd@lists.infradead.org" HEAD~1" please? Also, it is a good idea to add "Cc: Name Surname <e@ma.il>" lines to the patch description just before the Signed-off-by line so that the people who will end up applying it are CCed. That's at least Artem. > Regards, > gregor > > --- > drivers/mtd/devices/m25p80.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > index 1924d24..06beb3f 100644 > --- a/drivers/mtd/devices/m25p80.c > +++ b/drivers/mtd/devices/m25p80.c > @@ -873,6 +873,7 @@ static int __devinit m25p_probe(struct spi_device *spi) > else > flash->mtd.name = dev_name(&spi->dev); > + flash->mtd.owner = THIS_MODULE; > flash->mtd.type = MTD_NORFLASH; > flash->mtd.writesize = 1; > flash->mtd.flags = MTD_CAP_NORFLASH; Best regards, Marek Vasut
On Mon, 2012-10-08 at 10:10 +0200, Grégor Boirie wrote: > Marek, > > Sorry about that. I didn't really mean to submit an official patch at > first... > Nevermind, please find one just below. It misses a nice commit message and Signed-off-by. Please, try again. Or I can do it for you if you want (please, let me know), but then I will be the patch author. Also, please add the stable tree tag there, as this is a bugfix which is worth having in -stable.
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 1924d24..06beb3f 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -873,6 +873,7 @@ static int __devinit m25p_probe(struct spi_device *spi) else flash->mtd.name = dev_name(&spi->dev); + flash->mtd.owner = THIS_MODULE; flash->mtd.type = MTD_NORFLASH; flash->mtd.writesize = 1; flash->mtd.flags = MTD_CAP_NORFLASH; -- 1.7.4.1