Patchwork [v4] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.

login
register
mail settings
Submitter Graham Gower
Date Oct. 8, 2012, 6:43 a.m.
Message ID <5072760C.7060004@gmail.com>
Download mbox | patch
Permalink /patch/189918/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Graham Gower - Oct. 8, 2012, 6:43 a.m.
Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive
packets on a system with >4gb ram unless a 32bit DMA mask is used.

This issue has been around for years and a fix was sent 3.5 years ago, but
there was some debate as to whether it should instead be fixed as a PCI quirk.
http://www.spinics.net/lists/netdev/msg88670.html

However, 18 months later a similar workaround was introduced for another
chipset exhibiting the same problem.
http://www.spinics.net/lists/netdev/msg142287.html

Signed-off-by: Graham Gower <graham.gower@gmail.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 8, 2012, 7:07 a.m.
From: Graham Gower <graham.gower@gmail.com>
Date: Mon, 08 Oct 2012 17:13:24 +1030

> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to
> send/receive
> packets on a system with >4gb ram unless a 32bit DMA mask is used.

Please format this ascii text properly.  WHy is there a line
with just two words surrounded by full nearly 80-column lines?

> +		.matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),

THis is still formatted incorrectly, it's actually in the file
not due to your email client.

Can you indent the thing properly, please?

This is V4 of this patch, and suffering purely from first order coding
style and procedural stuff.  As you can imagine, it's very frustrating
to have to spend this much time getting such simple things taken care
of.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Graham Gower - Oct. 8, 2012, 9:08 a.m.
Well its pretty frustrating from my end too.

Fuck it, i dont care enough. I'll just keep patching kernels locally until my hardware expires.

On 08/10/2012, at 5:37 PM, David Miller <davem@davemloft.net> wrote:

> From: Graham Gower <graham.gower@gmail.com>
> Date: Mon, 08 Oct 2012 17:13:24 +1030
> 
>> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to
>> send/receive
>> packets on a system with >4gb ram unless a 32bit DMA mask is used.
> 
> Please format this ascii text properly.  WHy is there a line
> with just two words surrounded by full nearly 80-column lines?
> 
>> +        .matches = {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
> 
> THis is still formatted incorrectly, it's actually in the file
> not due to your email client.
> 
> Can you indent the thing properly, please?
> 
> This is V4 of this patch, and suffering purely from first order coding
> style and procedural stuff.  As you can imagine, it's very frustrating
> to have to spend this much time getting such simple things taken care
> of.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/drivers/net/ethernet/marvell/skge.c.bak
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -4143,6 +4143,13 @@ 
  			DMI_MATCH(DMI_BOARD_NAME, "nForce"),
  		},
  	},
+	{
+		.ident = "ASUS P5NSLI",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "P5NSLI")
+		},
+	},
  	{}
  };