Patchwork [v3] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.

login
register
mail settings
Submitter Graham Gower
Date Oct. 8, 2012, 5:54 a.m.
Message ID <50726AA4.7080901@gmail.com>
Download mbox | patch
Permalink /patch/189915/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Graham Gower - Oct. 8, 2012, 5:54 a.m.
Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive
packets on a system with >4gb ram unless a 32bit DMA mask is used.

This issue has been around for years and a fix was sent 3.5 years ago, but
there was some debate as to whether it should instead be fixed as a PCI quirk.
http://www.spinics.net/lists/netdev/msg88670.html

However, 18 months later a similar workaround was introduced for another
chipset exhibiting the same problem.
http://www.spinics.net/lists/netdev/msg142287.html

Signed-off-by: Graham Gower <graham.gower@gmail.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 8, 2012, 6:11 a.m.
From: Graham Gower <graham.gower@gmail.com>
Date: Mon, 08 Oct 2012 16:24:44 +1030

> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to
> send/receive
> packets on a system with >4gb ram unless a 32bit DMA mask is used.

This is still oddly formatted.

> +	{
> +		.ident = "ASUS P5NSLI",
> +		.matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),

And this is even worse than before.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Graham Gower - Oct. 8, 2012, 6:15 a.m.
Thunderbird must be screwing it. I hate mail clients. If I just pipe
the message to 'mail',
with a correct 'From:' line is that ok, or do I have to figure
something else out?

On 8 October 2012 16:41, David Miller <davem@davemloft.net> wrote:
> From: Graham Gower <graham.gower@gmail.com>
> Date: Mon, 08 Oct 2012 16:24:44 +1030
>
>> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to
>> send/receive
>> packets on a system with >4gb ram unless a 32bit DMA mask is used.
>
> This is still oddly formatted.
>
>> +     {
>> +             .ident = "ASUS P5NSLI",
>> +             .matches = {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
>
> And this is even worse than before.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 8, 2012, 6:21 a.m.
From: Graham Gower <graham.gower@gmail.com>
Date: Mon, 8 Oct 2012 16:45:33 +1030

> Thunderbird must be screwing it. I hate mail clients. If I just pipe
> the message to 'mail',
> with a correct 'From:' line is that ok, or do I have to figure
> something else out?

Documentation/email-clients.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -4143,6 +4143,13 @@ 
  			DMI_MATCH(DMI_BOARD_NAME, "nForce"),
  		},
  	},
+	{
+		.ident = "ASUS P5NSLI",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "P5NSLI")
+		},
+	},
  	{}
  };