Patchwork metadata_csum + unclean shutdown = failure to boot

login
register
mail settings
Submitter George Spelvin
Date Oct. 8, 2012, 3:17 a.m.
Message ID <20121008031704.17730.qmail@science.horizon.com>
Download mbox | patch
Permalink /patch/189882/
State Not Applicable
Headers show

Comments

George Spelvin - Oct. 8, 2012, 3:17 a.m.
I'm testing that patch, but you may want to fix it a bit more before submitting to
stable@...
fs/ext4/resize.c: In function 'update_backups':
fs/ext4/resize.c:973:39: error: too many arguments to function 'ext4_superblock_csum_set'
In file included from fs/ext4/ext4_jbd2.h:20:0,
                 from fs/ext4/resize.c:17:
fs/ext4/ext4.h:2049:13: note: declared here

The fix is of course obvious and I'm compiling it now.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tao Ma - Oct. 8, 2012, 4:03 a.m.
On 10/08/2012 11:17 AM, George Spelvin wrote:
> I'm testing that patch, but you may want to fix it a bit more before submitting to
> stable@...
> fs/ext4/resize.c: In function 'update_backups':
> fs/ext4/resize.c:973:39: error: too many arguments to function 'ext4_superblock_csum_set'
> In file included from fs/ext4/ext4_jbd2.h:20:0,
>                  from fs/ext4/resize.c:17:
> fs/ext4/ext4.h:2049:13: note: declared here
> 
> The fix is of course obvious and I'm compiling it now.
> 
> diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
> index 41f6ef6..e781259 100644
> --- a/fs/ext4/resize.c
> +++ b/fs/ext4/resize.c
> @@ -970,7 +970,7 @@ static void update_backups(struct super_block *sb,
>  		goto exit_err;
>  	}
>  
> -	ext4_superblock_csum_set(sb, (struct ext4_super_block *)data);
> +	ext4_superblock_csum_set(sb);
this line is already removed in my commit bef53b01 and will be in
stable. So this patch should work as expected.

Thanks
Tao
>  
>  	while ((group = ext4_list_backups(sb, &three, &five, &seven)) < last) {
>  		struct buffer_head *bh;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
George Spelvin - Oct. 8, 2012, 11:35 a.m.
Tao Ma <tm@tao.ma> wrote:
> This line is already removed in my commit bef53b01 and will be in
> stable. So this patch should work as expected.

Ah, okay.  Well, with that, it appears to be working; I can't
reproduce the problem any more.

Thanks to everyone for a significant bugfix starting with a vague
report over a weekend!
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 41f6ef6..e781259 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -970,7 +970,7 @@  static void update_backups(struct super_block *sb,
 		goto exit_err;
 	}
 
-	ext4_superblock_csum_set(sb, (struct ext4_super_block *)data);
+	ext4_superblock_csum_set(sb);
 
 	while ((group = ext4_list_backups(sb, &three, &five, &seven)) < last) {
 		struct buffer_head *bh;