Patchwork ata: sata_highbank: Fix section mismatch

login
register
mail settings
Submitter Fabio Estevam
Date Oct. 7, 2012, 10:46 p.m.
Message ID <1349649996-17115-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/189871/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Fabio Estevam - Oct. 7, 2012, 10:46 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

Building multi_v7_defconfig leads to the following warning:

WARNING: vmlinux.o(.data+0xf7d8): Section mismatch in reference from the variable ahci_highbank_driver to the function .init.text:ahci_highbank_probe()
The variable ahci_highbank_driver references
the function __init ahci_highbank_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Fix it by annotating ahci_highbank_probe as __devinit.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/ata/sata_highbank.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Fabio Estevam - Oct. 18, 2012, 7:12 p.m.
Jeff,

On Sun, Oct 7, 2012 at 7:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Building multi_v7_defconfig leads to the following warning:
>
> WARNING: vmlinux.o(.data+0xf7d8): Section mismatch in reference from the variable ahci_highbank_driver to the function .init.text:ahci_highbank_probe()
> The variable ahci_highbank_driver references
> the function __init ahci_highbank_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>
> Fix it by annotating ahci_highbank_probe as __devinit.

Can this be applied, please?

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
index 0d7c4c2..36a141a 100644
--- a/drivers/ata/sata_highbank.c
+++ b/drivers/ata/sata_highbank.c
@@ -260,7 +260,7 @@  static const struct of_device_id ahci_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, ahci_of_match);
 
-static int __init ahci_highbank_probe(struct platform_device *pdev)
+static int __devinit ahci_highbank_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct ahci_host_priv *hpriv;