Patchwork hw/qxl: qxl_dirty_surfaces: use uintptr_t

login
register
mail settings
Submitter Alon Levy
Date Oct. 7, 2012, 3:03 p.m.
Message ID <1349622215-15950-1-git-send-email-alevy@redhat.com>
Download mbox | patch
Permalink /patch/189842/
State New
Headers show

Comments

Alon Levy - Oct. 7, 2012, 3:03 p.m.
As suggested by Paolo Bonzini, to avoid possible integer overflow issues.

Signed-off-by: Alon Levy <alevy@redhat.com>
---
 hw/qxl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Gerd Hoffmann - Oct. 8, 2012, 11:10 a.m.
On 10/07/12 17:03, Alon Levy wrote:
> As suggested by Paolo Bonzini, to avoid possible integer overflow issues.

Patch added to spice patch queue, likewise the other two qxl fixes.

thanks,
  Gerd

Patch

diff --git a/hw/qxl.c b/hw/qxl.c
index 4effb66..97ae22a 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1811,7 +1811,7 @@  static void qxl_hw_text_update(void *opaque, console_ch_t *chardata)
 
 static void qxl_dirty_surfaces(PCIQXLDevice *qxl)
 {
-    intptr_t vram_start;
+    uintptr_t vram_start;
     int i;
 
     if (qxl->mode != QXL_MODE_NATIVE && qxl->mode != QXL_MODE_COMPAT) {
@@ -1822,7 +1822,7 @@  static void qxl_dirty_surfaces(PCIQXLDevice *qxl)
     qxl_set_dirty(&qxl->vga.vram, qxl->shadow_rom.draw_area_offset,
                   qxl->shadow_rom.surface0_area_size);
 
-    vram_start =  (intptr_t)memory_region_get_ram_ptr(&qxl->vram_bar);
+    vram_start = (uintptr_t)memory_region_get_ram_ptr(&qxl->vram_bar);
 
     /* dirty the off-screen surfaces */
     for (i = 0; i < qxl->ssd.num_surfaces; i++) {