| Submitter | Igor Grinberg |
|---|---|
| Date | Oct. 7, 2012, 11:17 a.m. |
| Message ID | <1349608655-11171-3-git-send-email-grinberg@compulab.co.il> |
| Download | mbox | patch |
| Permalink | /patch/189801/ |
| State | Rejected, archived |
| Delegated to: | Tom Rini |
| Headers | show |
Comments
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/07/12 04:17, Igor Grinberg wrote: > Increase the MAXARGS to support more than 16 arguments. > > Signed-off-by: Igor Grinberg <grinberg@compulab.co.il> --- > include/configs/cm_t35.h | 2 +- 1 files changed, 1 > insertions(+), 1 deletions(-) > > diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h > index 8e28fbc..e18fb5a 100644 --- a/include/configs/cm_t35.h +++ > b/include/configs/cm_t35.h @@ -256,7 +256,7 @@ /* Print Buffer Size > */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ > sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* > max number of command args */ +#define CONFIG_SYS_MAXARGS 32 /* > max number of command args */ /* Boot Argument Buffer Size */ > #define CONFIG_SYS_BARGSIZE (CONFIG_SYS_CBSIZE) Why? This is the max number of arguments to a command in U-Boot not the size of the command line arguments. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQcvOuAAoJENk4IS6UOR1W400P/1DjgD7n/1O19rZvZ0ET4wW1 b8hrNJXdWjuvQhB/suDurRHAaSicnBzavvAtg4ZGwMhqMfo4eg6fRfxNlB3fxMjE HO5F188x07ycnwma4uDDhAnKOVve/iAYZbZTvMXK6QYQCnfA2FKtdliwRsQ4rN3r a8nlkUc00mZrzKalk40KPP/8vWsaIc/EwgGaytnvpMRKqIGkZB/e1Ay028U678TH k+P12xSHoE8WqiidsIJQAO+fCK5RUkHo7uJWg9q1eHAw/0CeEGGlpj2p2vVSgEuh RxrsQn1/Bv6My5HuEhemcemgIbhHFCNFQ3LiY5cRDbDg49EJKkWkTq/zHhcxPJV0 zXAPINlTHUZ2NtWMHmk/VN7VdQL9at+IZvplGJ4oPSWLxi74ResdA64q17ICSiPN cZEOk0vTkr1ib37Bboi/NNGmHpuWi0XY9lLYrJJSsqtOg5wqJw7uRo89MOPn2EXR /pMHgqbaavYZzVw6wQ9Y1rxhhf+U+fo0x5nUbT9lGyXM9+FbXwsoXrf6eDmUNAPV 9t6/oVNh4FumZ64RHCucYUiluzXiV/eeKR6oeNfMhBzLqjec7gz0G/lMENoQada7 Du3RzAdsqbVGFL/4NKY2w1qZb+XDpQM+to4bJpRWeYq34potCwshmZJ4Ev7FSfpz eTnaIqbfCMk1nnAuDsYo =LfT0 -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/08/12 17:39, Tom Rini wrote: > On 10/07/12 04:17, Igor Grinberg wrote: >> Increase the MAXARGS to support more than 16 arguments. > >> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il> --- >> include/configs/cm_t35.h | 2 +- 1 files changed, 1 >> insertions(+), 1 deletions(-) > >> diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h >> index 8e28fbc..e18fb5a 100644 --- a/include/configs/cm_t35.h +++ >> b/include/configs/cm_t35.h @@ -256,7 +256,7 @@ /* Print Buffer Size >> */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ >> sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* >> max number of command args */ +#define CONFIG_SYS_MAXARGS 32 /* >> max number of command args */ /* Boot Argument Buffer Size */ >> #define CONFIG_SYS_BARGSIZE (CONFIG_SYS_CBSIZE) > > Why? This is the max number of arguments to a command in U-Boot not > the size of the command line arguments. Yes, I know that, but for some reason I was mislead by one of our engineers that we need to increase it. After checking the issue, I've came to a conclusion, that there was a missing quote(s) and we don't really need to increase the MAXARGS. Thanks for bringing my attention to this. You can drop this patch. - -- Regards, Igor. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJQdB/GAAoJEBDE8YO64Efa08oP/AkwuOWXy5h/P2LwYCBSc+ZC s9nEb+ZKdkICLrOaxaV6lCj9PEce3/PZIcPTYPXeFx3O3dW5ZAXSGiyLHTdB2Nut N+9Tfmi9lsOywWn7rmWbEsC67+ZVG28kq4IzCpPccV7HTjEHT8BTUVE55qGRJgDj jM1EcTYJ/MwoYx2ymel0XHDLqkUMzLChk47T8+OwiBj5SDAWXBcp4Iiufy5cBKB8 mqKbUkHklfzGt4PZrLB47MFJIl9B0y2864fyCrAz3cCS3d2W0Lf6MbUA1CguxsHY DCs3prineQFwatkgiNMTLzk0vCqpakLfzLEIVtOf4EI+IVdbyhNnTAGkacr0HMbt PqLnC8evfdYbaGNEeU1h4WCL6Fjzs0vD/KW29mGxNbj0tTE8TypXto8LbnF1MLJ6 vE0JKQMCu9oMA9ph4cQ00ZX6GMgbyBxnhpVQ02MyUanH+dylWtdkosoodcqdHf7p RhpkDnOJV8//dmTS32bMp42k8hNb7tXbU1ebFU6ZMwpzY+jEmqrl15E7mYmki/ZE F488LJQektTzEGZbMqpBtlIomLQ5OMRG2vhKz9gwY/FNvJsjKRw4+Owy+HGIOKwU IZzNaOhBp8U0yx+/70G5N2i2mnh6+on30vWfMC3x6x2yAy/Uu05ayG5NyK/sIsDP KydW6Ibm5CvE0fFwds4l =DXK1 -----END PGP SIGNATURE-----
Patch
diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h index 8e28fbc..e18fb5a 100644 --- a/include/configs/cm_t35.h +++ b/include/configs/cm_t35.h @@ -256,7 +256,7 @@ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command args */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE (CONFIG_SYS_CBSIZE)
Increase the MAXARGS to support more than 16 arguments. Signed-off-by: Igor Grinberg <grinberg@compulab.co.il> --- include/configs/cm_t35.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)