From patchwork Sat Oct 6 12:30:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 189696 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 654072C0334 for ; Sat, 6 Oct 2012 23:12:15 +1000 (EST) Received: from localhost ([::1]:37152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTXR-0005r5-DD for incoming@patchwork.ozlabs.org; Sat, 06 Oct 2012 08:31:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTWm-0004ZC-Dz for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKTWk-0000KP-PU for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:43 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:61635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTWk-00008K-J7 for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:42 -0400 Received: by mail-wi0-f181.google.com with SMTP id hq12so1308717wib.10 for ; Sat, 06 Oct 2012 05:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; bh=eRLKkOT3tqPLZGcYnfmoFj+4oz5XTYKO7/UJOW4PBhg=; b=k9y89dok2gNRT0Y1c69Oibvrg2Rp5AJossoS9BtEJLS+cZDb7Q4Fjd6rfONURoyK4R 2A2Js6fYZs0B/RawSWfZjgGD2iqnQ5n6wkiPPN5jbwVNNTUdmnC77NpEh4mifILIdKRs HBAlOkRP5w/RL6N9cssz/XO/vezPSvA3EVJjS8BjXj6Hn8KBHoVXxm4Q0lYfTqt0+uvF CWf57pARg95n/izGYB2+GUfrWTOvC5xNlKx+wetlIzVikpMohZSapGDB9xSpblcNhR9b 6b+G97NSL4O2Wcru//ULkvIguXjven4rLa7GkDhg7SmSnQJuo1AEStHKWhap2v8EZ/Mp gHqg== Received: by 10.180.80.104 with SMTP id q8mr9366725wix.6.1349526642235; Sat, 06 Oct 2012 05:30:42 -0700 (PDT) Received: from yakj.lan (93-34-169-1.ip50.fastwebnet.it. [93.34.169.1]) by mx.google.com with ESMTPS id m14sm7950701wie.8.2012.10.06.05.30.41 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 06 Oct 2012 05:30:41 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 6 Oct 2012 14:30:20 +0200 Message-Id: <1349526621-13939-14-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.12.1 In-Reply-To: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> References: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.181 Subject: [Qemu-devel] [PATCH 13/14] i386: optimize setbe X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This is looking at EFLAGS, but it can do so more efficiently with setcond. Signed-off-by: Paolo Bonzini Reviewed-by: Blue Swirl Reviewed-by: Richard Henderson --- target-i386/translate.c | 7 +++---- 1 file modificato, 3 inserzioni(+), 4 rimozioni(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index fb44839..342b9ec 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -1031,10 +1031,9 @@ static inline void gen_setcc_slow(DisasContext *s, int jcc_op, TCGv reg, bool in return; case JCC_BE: gen_compute_eflags(s); - tcg_gen_shri_tl(reg, cpu_cc_src, 6); - tcg_gen_or_tl(reg, reg, cpu_cc_src); - tcg_gen_andi_tl(reg, reg, 1); - break; + tcg_gen_andi_tl(reg, cpu_cc_src, 0x41); + tcg_gen_setcondi_tl(inv ? TCG_COND_EQ : TCG_COND_NE, reg, reg, 0); + return; case JCC_S: gen_compute_eflags_s(s, reg, inv); return;