From patchwork Sat Oct 6 12:30:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 189691 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C0ADB2C030F for ; Sat, 6 Oct 2012 23:02:15 +1000 (EST) Received: from localhost ([::1]:38449 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTXj-0006Xz-C2 for incoming@patchwork.ozlabs.org; Sat, 06 Oct 2012 08:31:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTWg-0004Hc-ME for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKTWe-0000Ck-0V for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:38 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:53432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTWd-00005r-R0 for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:35 -0400 Received: by mail-we0-f173.google.com with SMTP id t11so1531985wey.4 for ; Sat, 06 Oct 2012 05:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; bh=FfLBcSDVUnDjMEiYW6eMdMcrGMlQBm/PcVjhEeSBKtY=; b=v2PkjkaR6MUs+PVB++YHVPhEjrulzelE40JvmevRdoYghRNuBXc8T7IS+Ybya8SeML FMoZ0evE9Q9bdOP1t6FjC16L2/To69eMMb+KW1BZj0TE3h/otsykZWWv/R5W4XnuOXfm jjo+hhEtbb1s6uDtuB3H6s37jG9vNStPPqdNWQLJyaljuKsy8WSatBlhGDWG4mTr3/Tx syBCUfwzIj8sZXrrxP11yZMMOdqg3o+s/iVnCleXhh44N3sCoEyj2loXKXBRnEuhazS4 820Aai88I4tjxtRECOZPSHx+RK1bue5hHqXvzUHizljGQrzcM3umSSc8LAxfODVbOkSd V4AQ== Received: by 10.180.94.102 with SMTP id db6mr9295806wib.20.1349526635450; Sat, 06 Oct 2012 05:30:35 -0700 (PDT) Received: from yakj.lan (93-34-169-1.ip50.fastwebnet.it. [93.34.169.1]) by mx.google.com with ESMTPS id m14sm7950701wie.8.2012.10.06.05.30.34 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 06 Oct 2012 05:30:34 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 6 Oct 2012 14:30:14 +0200 Message-Id: <1349526621-13939-8-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.12.1 In-Reply-To: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> References: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.173 Subject: [Qemu-devel] [PATCH 07/14] i386: add helper functions to get other flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Introduce new functions to extract PF, SF, OF, ZF in addition to CF. These provide single entry points for optimizing accesses to a single flag. Signed-off-by: Paolo Bonzini Reviewed-by: Blue Swirl Reviewed-by: Richard Henderson --- target-i386/translate.c | 48 ++++++++++++++++++++++++++++++++++++------------ 1 file modificato, 36 inserzioni(+), 12 rimozioni(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index df81b78..8f22119 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -847,21 +847,49 @@ static void gen_compute_eflags(DisasContext *s, TCGv reg) tcg_gen_extu_i32_tl(reg, cpu_tmp2_i32); } +/* compute eflags.P to reg */ +static void gen_compute_eflags_p(DisasContext *s, TCGv reg) +{ + gen_compute_eflags(s, reg); + tcg_gen_shri_tl(reg, reg, 2); + tcg_gen_andi_tl(reg, reg, 1); +} + +/* compute eflags.S to reg */ +static void gen_compute_eflags_s(DisasContext *s, TCGv reg) +{ + gen_compute_eflags(s, reg); + tcg_gen_shri_tl(reg, reg, 7); + tcg_gen_andi_tl(reg, reg, 1); +} + +/* compute eflags.O to reg */ +static void gen_compute_eflags_o(DisasContext *s, TCGv reg) +{ + gen_compute_eflags(s, reg); + tcg_gen_shri_tl(reg, reg, 11); + tcg_gen_andi_tl(reg, reg, 1); +} + +/* compute eflags.Z to reg */ +static void gen_compute_eflags_z(DisasContext *s, TCGv reg) +{ + gen_compute_eflags(s, reg); + tcg_gen_shri_tl(reg, reg, 6); + tcg_gen_andi_tl(reg, reg, 1); +} + static inline void gen_setcc_slow_T0(DisasContext *s, int jcc_op) { switch(jcc_op) { case JCC_O: - gen_compute_eflags(s, cpu_T[0]); - tcg_gen_shri_tl(cpu_T[0], cpu_T[0], 11); - tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 1); + gen_compute_eflags_o(s, cpu_T[0]); break; case JCC_B: gen_compute_eflags_c(s, cpu_T[0]); break; case JCC_Z: - gen_compute_eflags(s, cpu_T[0]); - tcg_gen_shri_tl(cpu_T[0], cpu_T[0], 6); - tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 1); + gen_compute_eflags_z(s, cpu_T[0]); break; case JCC_BE: gen_compute_eflags(s, cpu_tmp0); @@ -870,14 +898,10 @@ static inline void gen_setcc_slow_T0(DisasContext *s, int jcc_op) tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 1); break; case JCC_S: - gen_compute_eflags(s, cpu_T[0]); - tcg_gen_shri_tl(cpu_T[0], cpu_T[0], 7); - tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 1); + gen_compute_eflags_s(s, cpu_T[0]); break; case JCC_P: - gen_compute_eflags(s, cpu_T[0]); - tcg_gen_shri_tl(cpu_T[0], cpu_T[0], 2); - tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 1); + gen_compute_eflags_p(s, cpu_T[0]); break; case JCC_L: gen_compute_eflags(s, cpu_tmp0);