From patchwork Sat Oct 6 12:30:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 189690 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C827F2C00DE for ; Sat, 6 Oct 2012 22:38:17 +1000 (EST) Received: from localhost ([::1]:35086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTX6-0004eh-CG for incoming@patchwork.ozlabs.org; Sat, 06 Oct 2012 08:31:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTWi-0004PH-VK for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKTWg-0000Fz-SE for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:40 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:56060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTWg-0000F2-LZ for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:38 -0400 Received: by mail-wg0-f53.google.com with SMTP id dr1so1675673wgb.10 for ; Sat, 06 Oct 2012 05:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; bh=tCeUcgbR/lxfT+DZxyp0nL9AKeSGbfCxZ7u4TJqJt34=; b=OXaR5Mpw6gAkpJOOyQTGwsCe5WUDjEAuo1gdOgzig9QeSldSQODkQRDI+l8YMBHtTA WE0Bzwt7siimBcVkYEEkB8d+N6DUw6lncR6HO/vp/5obM3AL9d/8JwLW7t1C1+Bb4/gm u8sImJ8zTN0rkyc2v4UWHFWZutXV6P7e7PfS9gHZ4nTmXk23d89DEMrAyYU43SQVwwRF yM537VFs7TQkOJeAO+PtCp0tReGIa9q+PQ/s4lo/7a+3tuH1gcGwKEbS8kUOwKJos/9D D3TRFzxB3IKceZHhIWxQXorD0qNiDt+cGpRvVopONIk6+0YArK28PhkN8EpFYQ2ZYov3 6/Xg== Received: by 10.180.89.7 with SMTP id bk7mr9388665wib.0.1349526637957; Sat, 06 Oct 2012 05:30:37 -0700 (PDT) Received: from yakj.lan (93-34-169-1.ip50.fastwebnet.it. [93.34.169.1]) by mx.google.com with ESMTPS id m14sm7950701wie.8.2012.10.06.05.30.37 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 06 Oct 2012 05:30:37 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 6 Oct 2012 14:30:16 +0200 Message-Id: <1349526621-13939-10-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.12.1 In-Reply-To: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> References: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.53 Subject: [Qemu-devel] [PATCH 09/14] i386: do not call helper to compute ZF/SF X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org ZF, SF and PF can always be computed from CC_DST except in the CC_OP_EFLAGS case (and CC_OP_DYNAMIC, which just resolves to CC_OP_EFLAGS in gen_compute_eflags). Use setcond to compute ZF and SF. We could also use a table lookup to compute PF. Signed-off-by: Paolo Bonzini Reviewed-by: Blue Swirl Reviewed-by: Richard Henderson --- target-i386/translate.c | 28 ++++++++++++++++++++++------ 1 file modificato, 22 inserzioni(+), 6 rimozioni(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 09512c3..daa36c1 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -859,9 +859,17 @@ static void gen_compute_eflags_p(DisasContext *s, TCGv reg) /* compute eflags.S to reg */ static void gen_compute_eflags_s(DisasContext *s, TCGv reg) { - gen_compute_eflags(s); - tcg_gen_shri_tl(reg, cpu_cc_src, 7); - tcg_gen_andi_tl(reg, reg, 1); + if (s->cc_op == CC_OP_DYNAMIC) { + gen_compute_eflags(s); + } + if (s->cc_op == CC_OP_EFLAGS) { + tcg_gen_shri_tl(reg, cpu_cc_src, 7); + tcg_gen_andi_tl(reg, reg, 1); + } else { + int size = (s->cc_op - CC_OP_ADDB) & 3; + gen_ext_tl(reg, cpu_cc_dst, size, true); + tcg_gen_setcondi_tl(TCG_COND_LT, reg, reg, 0); + } } /* compute eflags.O to reg */ @@ -875,9 +883,17 @@ static void gen_compute_eflags_o(DisasContext *s, TCGv reg) /* compute eflags.Z to reg */ static void gen_compute_eflags_z(DisasContext *s, TCGv reg) { - gen_compute_eflags(s); - tcg_gen_shri_tl(reg, cpu_cc_src, 6); - tcg_gen_andi_tl(reg, reg, 1); + if (s->cc_op == CC_OP_DYNAMIC) { + gen_compute_eflags(s); + } + if (s->cc_op == CC_OP_EFLAGS) { + tcg_gen_shri_tl(reg, cpu_cc_src, 6); + tcg_gen_andi_tl(reg, reg, 1); + } else { + int size = (s->cc_op - CC_OP_ADDB) & 3; + gen_ext_tl(reg, cpu_cc_dst, size, false); + tcg_gen_setcondi_tl(TCG_COND_EQ, reg, cpu_cc_dst, 0); + } } static inline void gen_setcc_slow_T0(DisasContext *s, int jcc_op)