Patchwork [U-Boot,2/9] disk: part_efi: re-order partition list printf, change case

login
register
mail settings
Submitter Stephen Warren
Date Oct. 5, 2012, 7:29 p.m.
Message ID <1349465394-3157-2-git-send-email-swarren@wwwdotorg.org>
Download mbox | patch
Permalink /patch/189570/
State Superseded
Delegated to: Tom Rini
Headers show

Comments

Stephen Warren - Oct. 5, 2012, 7:29 p.m.
From: Stephen Warren <swarren@nvidia.com>

The partition name is a long variable-length string. Move it last on
the line to ensure consistent layout and that the entries align with
the "header" line. Also, surround it in quotes, so if it's empty, it's
obvious that something is still being printed.

Also, change the case of the LBA numbers; lower-case looks nicer in my
opinion, and will be more consistent with the UUID printing that is
added later in this series.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 disk/part_efi.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Patch

diff --git a/disk/part_efi.c b/disk/part_efi.c
index 008177e..b6b2bf5 100644
--- a/disk/part_efi.c
+++ b/disk/part_efi.c
@@ -136,16 +136,16 @@  void print_part_efi(block_dev_desc_t * dev_desc)
 
 	debug("%s: gpt-entry at %p\n", __func__, gpt_pte);
 
-	printf("Part\tName\t\t\tStart LBA\tEnd LBA\n");
+	printf("Part\tStart LBA\tEnd LBA\t\tName\n");
 	for (i = 0; i < le32_to_int(gpt_head->num_partition_entries); i++) {
 		/* Stop at the first non valid PTE */
 		if (!is_pte_valid(&gpt_pte[i]))
 			break;
 
-		printf("%3d\t%-18s\t0x%08llX\t0x%08llX\n", (i + 1),
-			print_efiname(&gpt_pte[i]),
+		printf("%3d\t0x%08llx\t0x%08llx\t\"%s\"\n", (i + 1),
 			le64_to_int(gpt_pte[i].starting_lba),
-			le64_to_int(gpt_pte[i].ending_lba));
+			le64_to_int(gpt_pte[i].ending_lba),
+			print_efiname(&gpt_pte[i]));
 	}
 
 	/* Remember to free pte */