From patchwork Fri Oct 5 15:54:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 189517 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 073292C0329 for ; Sat, 6 Oct 2012 01:54:56 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1350057297; h=Comment: DomainKey-Signature:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=6nTF+69 65LyZVISJ49zPKaGScIY=; b=F03xoqUImJXJqGL6qlh7WBrKz0AYYAmirdYJPmB P47UeHvnskhIedxdOgfoKclS5Op40aP9tA6dT7IhbxUqWSq2bW7qpd5TNzafH28s VmSEnfZkVKoOV6Wp05B/aciFRGuuLdr4d3ls+2q31k1XPnLsvwIVDNen7l99IDPu p4Kg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:X-RZG-AUTH:X-RZG-CLASS-ID:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=L+QTDqaRgO8hqbUzpBqYSPhmXY717dteWgZHilLWSx7DKglpdMjcGJFTzNrCu3 Ifz0NJgroCwtwegnPBK7/ThPh/TncCfzPAELBb18UQwsEoiV/aQCc8ZndZ5TEzqu arpOjR4i8izMbU3bh7qlZtCPrZMvmio/QUzI/LOXGiC9s=; Received: (qmail 1273 invoked by alias); 5 Oct 2012 15:54:52 -0000 Received: (qmail 1265 invoked by uid 22791); 5 Oct 2012 15:54:51 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, TW_WW X-Spam-Check-By: sourceware.org Received: from mo-p00-ob.rzone.de (HELO mo-p00-ob.rzone.de) (81.169.146.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Oct 2012 15:54:44 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT2k715jHQaJercGObUOFkj18odoYNahU4Q== X-RZG-CLASS-ID: mo00 Received: from [192.168.0.22] (business-188-111-022-002.static.arcor-ip.net [188.111.22.2]) by smtp.strato.de (joses mo50) (RZmta 30.20 AUTH) with ESMTPA id z07534o95DTARO ; Fri, 5 Oct 2012 17:54:36 +0200 (CEST) Message-ID: <506F02BB.4050109@gjlay.de> Date: Fri, 05 Oct 2012 17:54:35 +0200 From: Georg-Johann Lay User-Agent: Thunderbird 2.0.0.24 (X11/20100302) MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org CC: Denis Chertykov , Eric Weddington , Joerg Wunsch Subject: [Patch,avr]: Remove -mshort-calls option X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org As already discussed, this patch removes the -mshort-calls command option from avr-gcc. Ok to apply? If the change is on order, changes to wwwdocs will follow, i.e. deprecate the option in 4.7 and tell it is removed in the 4.8 caveats. Johann * doc/invoke.texi (AVR Options): Remove -mshort-calls. * config/avr/avr.opt (-mshort-calls): Remove option. * config/avr/avr.h (AVR_HAVE_JMP_CALL): Don't depend on TARGET_SHORT_CALLS. Index: doc/invoke.texi =================================================================== --- doc/invoke.texi (revision 192131) +++ doc/invoke.texi (working copy) @@ -505,7 +505,7 @@ Objective-C and Objective-C++ Dialects}. @emph{AVR Options} @gccoptlist{-mmcu=@var{mcu} -maccumulate-args -mbranch-cost=@var{cost} @gol --mcall-prologues -mint8 -mno-interrupts -mrelax -mshort-calls @gol +-mcall-prologues -mint8 -mno-interrupts -mrelax @gol -mstrict-X -mtiny-stack} @emph{Blackfin Options} @@ -11291,13 +11291,6 @@ differ from instructions in the assemble Relaxing must be turned on if linker stubs are needed, see the section on @code{EIND} and linker stubs below. -@item -mshort-calls -@opindex mshort-calls -Use @code{RCALL}/@code{RJMP} instructions even on devices with -16@tie{}KiB or more of program memory, i.e.@: on devices that -have the @code{CALL} and @code{JMP} instructions. -See also the @code{-mrelax} command line option. - @item -msp8 @opindex msp8 Treat the stack pointer register as an 8-bit register, @@ -11560,7 +11553,7 @@ The device has a hardware multiplier. @item __AVR_HAVE_JMP_CALL__ The device has the @code{JMP} and @code{CALL} instructions. This is the case for devices with at least 16@tie{}KiB of program -memory and if @code{-mshort-calls} is not set. +memory. @item __AVR_HAVE_EIJMP_EICALL__ @item __AVR_3_BYTE_PC__ Index: config/avr/avr.opt =================================================================== --- config/avr/avr.opt (revision 192131) +++ config/avr/avr.opt (working copy) @@ -50,10 +50,6 @@ Target Report Undocumented Mask(ORDER_1) morder2 Target Report Undocumented Mask(ORDER_2) -mshort-calls -Target Report Mask(SHORT_CALLS) -Use rjmp/rcall (limited range) on >8K devices - mtiny-stack Target Report Mask(TINY_STACK) Change only the low 8 bits of the stack pointer Index: config/avr/avr.h =================================================================== --- config/avr/avr.h (revision 192131) +++ config/avr/avr.h (working copy) @@ -57,7 +57,7 @@ enum #define TARGET_CPU_CPP_BUILTINS() avr_cpu_cpp_builtins (pfile) -#define AVR_HAVE_JMP_CALL (avr_current_arch->have_jmp_call && !TARGET_SHORT_CALLS) +#define AVR_HAVE_JMP_CALL (avr_current_arch->have_jmp_call) #define AVR_HAVE_MUL (avr_current_arch->have_mul) #define AVR_HAVE_MOVW (avr_current_arch->have_movw_lpmx) #define AVR_HAVE_LPMX (avr_current_arch->have_movw_lpmx)