[SH] PR 54760 - Add thread pointer built-ins and GBR displacement addressing

On Thu, 2012-10-04 at 11:52 +0900, Kaz Kojima wrote:

> sh4-unknown-linux-gnu build failed during compiling libmudflap:
> 
> /exp/ldroot/dodes/xsh-gcc/./gcc/xgcc -B/exp/ldroot/dodes/xsh-gcc/./gcc/ -B/usr/local/sh4-unknown-linux-gnu/bin/ -B/usr/local/sh4-unknown-linux-gnu/lib/ -isystem /usr/local/sh4-unknown-linux-gnu/include -isystem /usr/local/sh4-unknown-linux-gnu/sys-include -DHAVE_CONFIG_H -I. -I../../../LOCAL/trunk/libmudflap -DLIBMUDFLAPTH -g -O2 -MT libmudflapth_la-mf-runtime.lo -MD -MP -MF .deps/libmudflapth_la-mf-runtime.Tpo -c ../../../LOCAL/trunk/libmudflap/mf-runtime.c -o libmudflapth_la-mf-runtime.o
> ../../../LOCAL/trunk/libmudflap/mf-runtime.c: In function 'begin_recursion_protect1':
> ../../../LOCAL/trunk/libmudflap/mf-runtime.c:152:1: internal compiler error: Segmentation fault
>  }
>  ^
> 0x8529c60 crash_signal
> 	../../LOCAL/trunk/gcc/toplev.c:335
> 0x8771a87 sh_find_base_reg_disp
> 	../../LOCAL/trunk/gcc/config/sh/sh.c:13344
> 0x8791554 sh_find_equiv_gbr_addr(rtx_def*, rtx_def*)
> 	../../LOCAL/trunk/gcc/config/sh/sh.c:13395
> 0x87ce6cf gen_split_1029(rtx_def*, rtx_def**)
> 	../../LOCAL/trunk/gcc/config/sh/sh.md:10184
> 0x87ea6e0 split_1
> 	../../LOCAL/trunk/gcc/config/sh/sh.md:10183
> 0x87ea6e0 split_3
> 	../../LOCAL/trunk/gcc/config/sh/sh.md:7082
> 0x82bf8a1 try_split(rtx_def*, rtx_def*, int)
> 	../../LOCAL/trunk/gcc/emit-rtl.c:3503
> 0x849c642 split_insn
> 	../../LOCAL/trunk/gcc/recog.c:2809
> 0x84a08b5 split_all_insns()
> 	../../LOCAL/trunk/gcc/recog.c:2899
> 0x84a09a7 rest_of_handle_split_all_insns
> 	../../LOCAL/trunk/gcc/recog.c:3751
> 
> Looks prev_nonnote_insn returns a barrier there:
> 
> (gdb) fr 0
> #0  0x08771a87 in sh_find_base_reg_disp (insn=<optimized out>, x=0xb79ddd40, 
>     base_reg=0x0, disp=0) at ../../LOCAL/trunk/gcc/config/sh/sh.c:13344
> 13344		  if (p != NULL && GET_CODE (p) == SET && REG_P (XEXP (p, 0))
> (gdb) p p
> $1 = (rtx) 0xafafafaf
> (gdb) p i
> $2 = (rtx_def *) 0xb79ecc3c
> (gdb) call debug_rtx(i)
> (barrier 216 215 217)

Oops.  Thanks for tracing this.
It should have been:
for (...)
  {
    if (!NONJUMP_INSN_P (i))
      continue;
    rtx p = PATTERN (i);
    ...
  }

> > 	(builtin_description): Add is_enabled member.
> > 	(shmedia_builtin, sh1_builtin): New functions.
> > 	(signature_args): Add SH_BLTIN_VP.
> > 	(bdesc): Use shmedia_builtin for existing built-ins.  Add 
> > 	__builtin_thread_pointer and __builtin_set_thread_pointer as 
> > 	sh1_builtin.
> > 	(sh_media_init_builtins, sh_init_builtins): Merge into single 
> > 	function sh_init_builtins.  Add is_enabled checking.
> > 	(sh_media_builtin_decl, sh_builtin_decl): Merge into single 
> > 	function sh_builtin_decl.  Add is_enabled checking.
> 
> It would be better to separate this part except new thread pointer
> builtins into an independent patch which should be tested also with
> sh64-elf build, though now unified sh64-elf build is failing.
> I'd like to commit a quick fix for sh64-elf build failure.

Do you mean something like the attached patch as a preparation step?
(checked with 'make all')

Cheers,
Oleg

gcc/ChangeLog:

	PR target/54760
	* config/sh/sh.c (builtin_description): Add is_enabled member.
	(shmedia_builtin_p): New function.
	(bdesc): Use shmedia_builtin_p for existing built-ins.
	(sh_media_init_builtins, sh_init_builtins): Merge into single
	function sh_init_builtins.  Add is_enabled checking.  Move
	variable declarations to where they are actually used.
	(sh_media_builtin_decl, sh_builtin_decl): Merge into single 
	function sh_builtin_decl.  Add is_enabled checking.
	(sh_expand_builtin): Move variable declarations to where they
	are actually used.

[SH] PR 54760 - Add thread pointer built-ins and GBR displacement addressing

Commit Message

Comments

Patch