Patchwork versatilepb: Use symbolic indices for ARM PIC

login
register
mail settings
Submitter Stefan Weil
Date Oct. 4, 2012, 8:49 p.m.
Message ID <1349383783-21392-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/189345/
State Accepted
Headers show

Comments

Stefan Weil - Oct. 4, 2012, 8:49 p.m.
It is more readable, and all other code does it like that, too.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 hw/versatilepb.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Stefan Hajnoczi - Oct. 5, 2012, 1:50 p.m.
On Thu, Oct 04, 2012 at 10:49:43PM +0200, Stefan Weil wrote:
> It is more readable, and all other code does it like that, too.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  hw/versatilepb.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/hw/versatilepb.c b/hw/versatilepb.c
index 7a92034..b3f8077 100644
--- a/hw/versatilepb.c
+++ b/hw/versatilepb.c
@@ -211,7 +211,8 @@  static void versatile_init(ram_addr_t ram_size,
 
     cpu_pic = arm_pic_init_cpu(cpu);
     dev = sysbus_create_varargs("pl190", 0x10140000,
-                                cpu_pic[0], cpu_pic[1], NULL);
+                                cpu_pic[ARM_PIC_CPU_IRQ],
+                                cpu_pic[ARM_PIC_CPU_FIQ], NULL);
     for (n = 0; n < 32; n++) {
         pic[n] = qdev_get_gpio_in(dev, n);
     }