From patchwork Thu Oct 4 21:20:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 189332 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7A0072C03BD for ; Fri, 5 Oct 2012 07:23:27 +1000 (EST) Received: from localhost ([::1]:55728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJstA-00033W-0B for incoming@patchwork.ozlabs.org; Thu, 04 Oct 2012 17:23:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJst1-00031S-3C for qemu-devel@nongnu.org; Thu, 04 Oct 2012 17:23:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJssz-00018n-Ca for qemu-devel@nongnu.org; Thu, 04 Oct 2012 17:23:14 -0400 Received: from mail-da0-f45.google.com ([209.85.210.45]:34743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJssz-00018Y-6O for qemu-devel@nongnu.org; Thu, 04 Oct 2012 17:23:13 -0400 Received: by mail-da0-f45.google.com with SMTP id n15so425813dad.4 for ; Thu, 04 Oct 2012 14:23:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :user-agent:x-gm-message-state; bh=asL3xCABsWL1Dkwb1FR1rFPvJHmQiNE/e/cTKuPc3EQ=; b=FoxE/VTfPtvSnUObiXlQs6WIyuR8CRhmxnMxMymx+fvT3FURYrlYQfn9SGT76pNENG hllsrXv64giB+S4A4ldrDuGjJkmv5lOujM2oPmfyDSgc4vcVc0wlpu8xlte3S6b4uyj/ UTEijmgVqaILuzWL66x5TzP8eyl9fVEmcYX94Nh3w865Iy6Ye85Vu5LzmCaIfLfJnbhR qpic5xGkYYnqFj/FArp7pG25XxMQiGQ8hnj/JoGx9+HG4qE5n1sKUnHrrG2lE/yGoQyJ BMM0XW1c0pQSY1T6Zb35BGplKrer7oDMoQWTSFcltvQq5CVZ3xBO4w/2YinufE3Jw+r5 JosQ== Received: by 10.66.83.201 with SMTP id s9mr6283100pay.74.1349385790545; Thu, 04 Oct 2012 14:23:10 -0700 (PDT) Received: from localhost (c-67-168-183-230.hsd1.wa.comcast.net. [67.168.183.230]) by mx.google.com with ESMTPS id kr4sm345154pbc.76.2012.10.04.14.23.08 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 04 Oct 2012 14:23:09 -0700 (PDT) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Thu, 4 Oct 2012 14:20:03 -0700 Message-Id: <20121004210642.527075904@linuxfoundation.org> X-Mailer: git-send-email 1.7.12.2.421.g261b511 In-Reply-To: <20121004210635.449598766@linuxfoundation.org> References: <20121004210635.449598766@linuxfoundation.org> User-Agent: quilt/0.60-2.1.2 X-Gm-Message-State: ALoCoQljiRyNwuhPhr4gd61VlHYpcYiP8ZkJKCYBarKy/TbXN+hm3nEnFiOgteUwV2zrV1+D0V+z X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.210.45 Cc: Greg Kroah-Hartman , Marcelo Tosatti , Michael Tokarev , Borislav Petkov , Tomas Racek , qemu-devel@nongnu.org, Avi Kivity , Anthony Liguori , "H. Peter Anvin" , Ben Jencks , Ingo Molnar , alan@lxorguk.ukuu.org.uk, Alan Cox Subject: [Qemu-devel] [ 56/58] x86/alternatives: Fix p6 nops on non-modular kernels X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org 3.5-stable review patch. If anyone has any objections, please let me know. ------------------ From: Avi Kivity commit cb09cad44f07044d9810f18f6f9a6a6f3771f979 upstream. Probably a leftover from the early days of self-patching, p6nops are marked __initconst_or_module, which causes them to be discarded in a non-modular kernel. If something later triggers patching, it will overwrite kernel code with garbage. Reported-by: Tomas Racek Signed-off-by: Avi Kivity Cc: Michael Tokarev Cc: Borislav Petkov Cc: Marcelo Tosatti Cc: qemu-devel@nongnu.org Cc: Anthony Liguori Cc: H. Peter Anvin Cc: Alan Cox Cc: Alan Cox Link: http://lkml.kernel.org/r/5034AE84.90708@redhat.com Signed-off-by: Ingo Molnar Cc: Ben Jencks Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/alternative.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -160,7 +160,7 @@ static const unsigned char * const k7_no #endif #ifdef P6_NOP1 -static const unsigned char __initconst_or_module p6nops[] = +static const unsigned char p6nops[] = { P6_NOP1, P6_NOP2,