From patchwork Thu Oct 4 20:58:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 189323 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C50942C03A4 for ; Fri, 5 Oct 2012 06:58:39 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1349989120; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=SQKzB4+ fOgvtd2gJzgDXyNLHITA=; b=Kwc04nqfE5+/2/qZshWTtAKo55W/mdRFHlmc/9p y26Ybd92IMuikXVOEAgxU9AFONUi8Q2M7MrH1DBV3F4/75Jd1Zsmk+pnuHrXv6+S WFe5K6b4pe/FXfQpUQe/AXWNHbZtViJ5dGNEje6uOpdgZId1Uqdq9t44t8PnD2rd I0ko= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=bm9Pbgv5OigGdFTQqJnhNWZhlO1aeq7Pqf/3fnggxZuuyLgi2H9Y3CaO8C4bgd Jq+ZvS5/a7sSSJMoSF1jj+RtkYLoXLeDHS4rOxgNu7DAp6VDbD9r1L6ZQ8lj470q y3slZa1lDsH92aVbCKH9tdSmN5OhheUzl3sFxt7WEUU6o=; Received: (qmail 17350 invoked by alias); 4 Oct 2012 20:58:36 -0000 Received: (qmail 17337 invoked by uid 22791); 4 Oct 2012 20:58:35 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_SPAMHAUS_DROP, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Oct 2012 20:58:27 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q94KwQhq004820 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 4 Oct 2012 16:58:27 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-55.phx2.redhat.com [10.3.113.55]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q94KwQip022545 for ; Thu, 4 Oct 2012 16:58:26 -0400 Message-ID: <506DF872.8010101@redhat.com> Date: Thu, 04 Oct 2012 14:58:26 -0600 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: gcc-patches Subject: [BZ 50356] Obvious bugfix in h8300 bits X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This is a pretty obvious typo/thinko. Interestingly enough, fixing it makes absolutely no difference in the generated code for newlib ;-) One could make an argument it should just be zapped, but I'm not going to open that can of worms today. Obviously I tested this by building newlib before and after this change :-) * PR target/50356 * config/h8300/h8300.c (h8300_rtx_costs): Fix typo in CONST_INT case. Index: config/h8300/h8300.c =================================================================== --- config/h8300/h8300.c (revision 192102) +++ config/h8300/h8300.c (working copy) @@ -1,6 +1,6 @@ /* Subroutines for insn-output.c for Renesas H8/300. Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, - 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 + 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Free Software Foundation, Inc. Contributed by Steve Chamberlain (sac@cygnus.com), Jim Wilson (wilson@cygnus.com), and Doug Evans (dje@cygnus.com). @@ -1244,7 +1244,7 @@ *total = 0; return true; } - if (-4 <= n || n <= 4) + if (-4 <= n && n <= 4) { switch ((int) n) {