Patchwork net: sunrpc: xdr: Change message to pr_debug level

login
register
mail settings
Submitter Fabio Estevam
Date Oct. 4, 2012, 2:21 p.m.
Message ID <1349360495-29325-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/189163/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Fabio Estevam - Oct. 4, 2012, 2:21 p.m.
commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in xdr_align_pages)
has added a pr_info that floods dmesg when booting via NFS.

There is also a note in the commit log: "Warning! Contains debugging printks!"

,so change it to pr_debug instead.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 net/sunrpc/xdr.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Marek Vasut - Oct. 4, 2012, 2:25 p.m.
Dear Fabio Estevam,

> commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in
> xdr_align_pages) has added a pr_info that floods dmesg when booting via
> NFS.
> 
> There is also a note in the commit log: "Warning! Contains debugging
> printks!"
> 
> ,so change it to pr_debug instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Reviewed-by: Marek Vasut <marex@denx.de>

> ---
>  net/sunrpc/xdr.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e30842b..6983efc 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -749,7 +749,7 @@ static unsigned int xdr_align_pages(struct xdr_stream
> *xdr, unsigned int len) xdr_shrink_pagelen(buf, buf->page_len - len);
>  		xdr->nwords = XDR_QUADLEN(buf->len - cur);
>  	} else
> -		pr_info("%s: Optimised away a data move!\n", __func__);
> +		pr_debug("%s: Optimised away a data move!\n", __func__);
>  	return len;
>  }

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Trond Myklebust - Oct. 4, 2012, 2:51 p.m.
> -----Original Message-----
> From: Marek Vasut [mailto:marex@denx.de]
> Sent: Thursday, October 04, 2012 7:25 AM
> To: Fabio Estevam
> Cc: davem@davemloft.net; Myklebust, Trond; netdev@vger.kernel.org;
> linux-nfs@vger.kernel.org
> Subject: Re: [PATCH] net: sunrpc: xdr: Change message to pr_debug level
> 
> Dear Fabio Estevam,
> 
> > commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in
> > xdr_align_pages) has added a pr_info that floods dmesg when booting
> > via NFS.
> >
> > There is also a note in the commit log: "Warning! Contains debugging
> > printks!"
> >

...which meant that it contained debugging code, and was obviously not appropriate for merging upstream. The final version has already dropped the debugging printks.

Trond
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marek Vasut - Oct. 4, 2012, 2:57 p.m.
Dear Myklebust, Trond,

> > -----Original Message-----
> > From: Marek Vasut [mailto:marex@denx.de]
> > Sent: Thursday, October 04, 2012 7:25 AM
> > To: Fabio Estevam
> > Cc: davem@davemloft.net; Myklebust, Trond; netdev@vger.kernel.org;
> > linux-nfs@vger.kernel.org
> > Subject: Re: [PATCH] net: sunrpc: xdr: Change message to pr_debug level
> > 
> > Dear Fabio Estevam,
> > 
> > > commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in
> > > xdr_align_pages) has added a pr_info that floods dmesg when booting
> > > via NFS.
> > > 
> > > There is also a note in the commit log: "Warning! Contains debugging
> > > printks!"
> 
> ...which meant that it contained debugging code, and was obviously not
> appropriate for merging upstream. The final version has already dropped
> the debugging printks.

Uh oh, the version with debug prints made it into -next .

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index e30842b..6983efc 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -749,7 +749,7 @@  static unsigned int xdr_align_pages(struct xdr_stream *xdr, unsigned int len)
 		xdr_shrink_pagelen(buf, buf->page_len - len);
 		xdr->nwords = XDR_QUADLEN(buf->len - cur);
 	} else
-		pr_info("%s: Optimised away a data move!\n", __func__);
+		pr_debug("%s: Optimised away a data move!\n", __func__);
 	return len;
 }