diff mbox

[RFA,1/5] New port: CR16: Remove "gdb" from noconfigdirs in configure.ac

Message ID C6CA53A2A46BA7469348BDBD663AB65845B2FF78@KCHJEXMB03.kpit.com
State New
Headers show

Commit Message

Kaushik Phatak Oct. 4, 2012, 10:17 a.m. UTC 
Hi,
This patch is one of patch set to add a new port (National Instruments CR16) in gdb.
This patch will,
- Remove "gdb" from noconfigdirs in top-level configure.ac.
- Add target-lobgloss
- Make target OS independent in config.sub

OK for gcc and binutils?

Regards,
Kaushik


2012-10-04  Kaushik Phatak  <kaushik.phatak@kpitcummins.com>
Changelog
	* configure.ac (noconfigdirs): Remove gdb. Add target-libgloss.
	* configure: Regenerate.
	* config.sub: Make target OS independent

Comments

Pedro Alves Oct. 4, 2012, 1:29 p.m. UTC | #1 
On 10/04/2012 11:17 AM, Kaushik Phatak wrote:
> Hi,
> This patch is one of patch set to add a new port (National Instruments CR16) in gdb.
> This patch will,
> - Remove "gdb" from noconfigdirs in top-level configure.ac.
> - Add target-lobgloss

I can't see how adding target-libgloss is relevant to a gdb port.
Please keep separate logical changes in separate logical patches, each
with its own description/justification.

> - Make target OS independent in config.sub

config.sub is maintained elsewhere.  The right procedure is to send the change
upstream, and then merge upstream into our tree.
Please see the head of the script for instructions.
diff mbox

Patch

--- ./gdb_src.orig/configure	2012-06-28 17:20:52.000000000 +0530
+++ ./gdb_src/configure	2012-08-17 16:56:10.000000000 +0530
@@ -3447,7 +3447,7 @@  case "${target}" in
     noconfigdirs="$noconfigdirs target-libgloss gdb"
     ;;
   cr16-*-*)
-    noconfigdirs="$noconfigdirs gdb"
+    noconfigdirs="$noconfigdirs target-libgloss"
     ;;
   d10v-*-*)
     noconfigdirs="$noconfigdirs target-libgloss"
--- ./gdb_src.orig/configure.ac	2012-08-17 23:07:18.000000000 +0530
+++ ./gdb_src/configure.ac	2012-08-17 16:56:17.000000000 +0530
@@ -873,7 +873,7 @@  case "${target}" in
     noconfigdirs="$noconfigdirs target-libgloss gdb"
     ;;
   cr16-*-*)
-    noconfigdirs="$noconfigdirs gdb"
+    noconfigdirs="$noconfigdirs target-libgloss"
     ;;
   d10v-*-*)
     noconfigdirs="$noconfigdirs target-libgloss"
--- ./gdb_src.orig/config.sub	2012-04-25 21:23:25.000000000 +0530
+++ ./gdb_src/config.sub	2012-09-24 11:26:00.000000000 +0530
@@ -575,7 +575,6 @@  case $basic_machine in
 		;;
 	cr16 | cr16-*)
 		basic_machine=cr16-unknown
-		os=-elf
 		;;
 	crds | unos)
 		basic_machine=m68k-crds