Patchwork [U-Boot] trats: Enable EXT4 and EFI partitions support on Samsung's Trats board

login
register
mail settings
Submitter Łukasz Majewski
Date Oct. 4, 2012, 9:27 a.m.
Message ID <1349342852-23216-1-git-send-email-l.majewski@samsung.com>
Download mbox | patch
Permalink /patch/189078/
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Comments

Łukasz Majewski - Oct. 4, 2012, 9:27 a.m.
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 include/configs/trats.h |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Minkyu Kang - Oct. 12, 2012, 2:54 a.m.
Dear Lukasz,

On 4 October 2012 18:27, Lukasz Majewski <l.majewski@samsung.com> wrote:
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  include/configs/trats.h |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/trats.h b/include/configs/trats.h
> index b3b5a3d..aaf64eb 100644
> --- a/include/configs/trats.h
> +++ b/include/configs/trats.h
> @@ -104,6 +104,9 @@
>  #define CONFIG_CMD_FAT
>  #define CONFIG_FAT_WRITE

So, do we need to keep FAT related features?

>
> +/* EXT4 */
> +#define CONFIG_CMD_EXT4
> +
>  /* USB Composite download gadget - g_dnl */
>  #define CONFIG_USBDOWNLOAD_GADGET
>  #define CONFIG_DFU_FUNCTION
> @@ -167,7 +170,7 @@
>         "meminfo=crashkernel=32M@0x50000000\0" \
>         "nfsroot=/nfsroot/arm\0" \
>         "bootblock=" CONFIG_BOOTBLOCK "\0" \
> -       "loaduimage=fatload mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 uImage\0" \
> +       "loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 uImage\0" \
>         "mmcdev=0\0" \
>         "mmcbootpart=2\0" \
>         "mmcrootpart=3\0" \
> @@ -208,6 +211,7 @@
>  #define CONFIG_ENV_OFFSET              ((32 - 4) << 10) /* 32KiB - 4KiB */
>
>  #define CONFIG_DOS_PARTITION

also dos partition.

> +#define CONFIG_EFI_PARTITION
>

Thanks
Minkyu Kang.
Łukasz Majewski - Oct. 12, 2012, 6:57 a.m.
Hi Minkyu,

> Dear Lukasz,
> 
> On 4 October 2012 18:27, Lukasz Majewski <l.majewski@samsung.com>
> wrote:
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >  include/configs/trats.h |    6 +++++-
> >  1 files changed, 5 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/configs/trats.h b/include/configs/trats.h
> > index b3b5a3d..aaf64eb 100644
> > --- a/include/configs/trats.h
> > +++ b/include/configs/trats.h
> > @@ -104,6 +104,9 @@
> >  #define CONFIG_CMD_FAT
> >  #define CONFIG_FAT_WRITE
> 
> So, do we need to keep FAT related features?

Since the ext4 is not fully stabilized - I would opt for keeping the
FAT support for default (mainline) trats configuration.
> 
> >
> > +/* EXT4 */
> > +#define CONFIG_CMD_EXT4
> > +
> >  /* USB Composite download gadget - g_dnl */
> >  #define CONFIG_USBDOWNLOAD_GADGET
> >  #define CONFIG_DFU_FUNCTION
> > @@ -167,7 +170,7 @@
> >         "meminfo=crashkernel=32M@0x50000000\0" \
> >         "nfsroot=/nfsroot/arm\0" \
> >         "bootblock=" CONFIG_BOOTBLOCK "\0" \
> > -       "loaduimage=fatload mmc ${mmcdev}:${mmcbootpart} 0x40007FC0
> > uImage\0" \
> > +       "loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart}
> > 0x40007FC0 uImage\0" \ "mmcdev=0\0" \
> >         "mmcbootpart=2\0" \
> >         "mmcrootpart=3\0" \
> > @@ -208,6 +211,7 @@
> >  #define CONFIG_ENV_OFFSET              ((32 - 4) << 10) /* 32KiB -
> > 4KiB */
> >
> >  #define CONFIG_DOS_PARTITION
> 
> also dos partition.

EFI patches are on the way to mainline, but aren't accepted. I would
like to keep DOS partitions support at least until EFI support is done.

> 
> > +#define CONFIG_EFI_PARTITION
> >
> 
> Thanks
> Minkyu Kang.

Patch

diff --git a/include/configs/trats.h b/include/configs/trats.h
index b3b5a3d..aaf64eb 100644
--- a/include/configs/trats.h
+++ b/include/configs/trats.h
@@ -104,6 +104,9 @@ 
 #define CONFIG_CMD_FAT
 #define CONFIG_FAT_WRITE
 
+/* EXT4 */
+#define CONFIG_CMD_EXT4
+
 /* USB Composite download gadget - g_dnl */
 #define CONFIG_USBDOWNLOAD_GADGET
 #define CONFIG_DFU_FUNCTION
@@ -167,7 +170,7 @@ 
 	"meminfo=crashkernel=32M@0x50000000\0" \
 	"nfsroot=/nfsroot/arm\0" \
 	"bootblock=" CONFIG_BOOTBLOCK "\0" \
-	"loaduimage=fatload mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 uImage\0" \
+	"loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 uImage\0" \
 	"mmcdev=0\0" \
 	"mmcbootpart=2\0" \
 	"mmcrootpart=3\0" \
@@ -208,6 +211,7 @@ 
 #define CONFIG_ENV_OFFSET		((32 - 4) << 10) /* 32KiB - 4KiB */
 
 #define CONFIG_DOS_PARTITION
+#define CONFIG_EFI_PARTITION
 
 #define CONFIG_SYS_INIT_SP_ADDR	(CONFIG_SYS_LOAD_ADDR - GENERATED_GBL_DATA_SIZE)
 #define CONFIG_SYS_CACHELINE_SIZE       32