Patchwork New package liblog4c-localtime

login
register
mail settings
Submitter Alexander Varnin
Date Oct. 4, 2012, 9:08 a.m.
Message ID <1349341682-12387-1-git-send-email-fenixk19@mail.ru>
Download mbox | patch
Permalink /patch/189067/
State Superseded
Headers show

Comments

Alexander Varnin - Oct. 4, 2012, 9:08 a.m.
---
 package/Config.in                                |    1 +
 package/liblog4c-localtime/Config.in             |    9 +++++++++
 package/liblog4c-localtime/liblog4c-localtime.mk |   11 +++++++++++
 3 files changed, 21 insertions(+), 0 deletions(-)
 create mode 100644 package/liblog4c-localtime/Config.in
 create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk
Alexander Varnin - Oct. 4, 2012, 9:10 a.m.
Hello. I'm working on old buildroot version 2012.02.
For some reason, this package doesn't get include in build, even when i 
check config in menuconfig. What else should i have to do, to make 
package building?

04.10.2012 13:08, Alexander Varnin пишет:
> ---
>   package/Config.in                                |    1 +
>   package/liblog4c-localtime/Config.in             |    9 +++++++++
>   package/liblog4c-localtime/liblog4c-localtime.mk |   11 +++++++++++
>   3 files changed, 21 insertions(+), 0 deletions(-)
>   create mode 100644 package/liblog4c-localtime/Config.in
>   create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 8a7c9c4..25752e5 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
>   source "package/orc/Config.in"
>   source "package/poco/Config.in"
>   source "package/startup-notification/Config.in"
> +source "package/liblog4c-localtime/Config.in"
>   endmenu
>   
>   menu "Text and terminal handling"
> diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
> new file mode 100644
> index 0000000..58797be
> --- /dev/null
> +++ b/package/liblog4c-localtime/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_LIBLOG4C
> +	bool "liblog4c-localtime"
> +	help
> +	  Log4c is a library of C for flexible logging to files, syslog
> +	  and other destinations.
> +	  This version is with localtime patch, to make lib show times in
> +	  local timezone.
> +
> +	  https://github.com/rcmadruga/log4c-localtime
> diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
> new file mode 100644
> index 0000000..f0599c3
> --- /dev/null
> +++ b/package/liblog4c-localtime/liblog4c-localtime.mk
> @@ -0,0 +1,11 @@
> + #############################################################
> + #
> + # liblog4c
> + #
> + #############################################################
> + LIBLOG4C_VERSION = 1.2.1
> + LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git
> + LIBLOG4C_INSTALL_STAGING = YES
> +
> + $(eval $(call AUTOTARGETS))
> +
Samuel Martin - Oct. 4, 2012, 9:24 a.m.
Hi Alexander,

2012/10/4 Alexander Varnin <fenixk19@mail.ru>:
> Hello. I'm working on old buildroot version 2012.02.
> For some reason, this package doesn't get include in build, even when i
> check config in menuconfig. What else should i have to do, to make package
> building?
>
> 04.10.2012 13:08, Alexander Varnin пишет:
>
[...]
>> diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk
>> b/package/liblog4c-localtime/liblog4c-localtime.mk
>> new file mode 100644
>> index 0000000..f0599c3
>> --- /dev/null
>> +++ b/package/liblog4c-localtime/liblog4c-localtime.mk
>> @@ -0,0 +1,11 @@
>> + #############################################################
>> + #
>> + # liblog4c
>> + #
>> + #############################################################
>> + LIBLOG4C_VERSION = 1.2.1
>> + LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git
>> + LIBLOG4C_INSTALL_STAGING = YES
>> +
>> + $(eval $(call AUTOTARGETS))
>> +

The problem is the package name "liblog4c-localtime" does not match
the match the make target translation, which should be
"LIBLOG4C_LOCALTIME" instead of just "LIBLOG4C".

So, fix either the package name or the variables in the *.mk file,
then it should work.


Regards,
Thomas Petazzoni - Oct. 4, 2012, 1:36 p.m.
On Thu, 4 Oct 2012 11:24:04 +0200, Samuel Martin wrote:

> >> + $(eval $(call AUTOTARGETS))

And also if you want us to apply this patch in the current Buildroot
version, this has to be changed to:

$(eval $(autotools-package))

Thanks!

Thomas
Arnout Vandecappelle - Oct. 5, 2012, 7:47 p.m.
On 04/10/12 11:08, Alexander Varnin wrote:

  Add a Signed-off-by line for yourself.  This is a short way for you to
assert that you are entitled to contribute the patch under buildroot's
GPL license.  See  http://kerneltrap.org/files/Jeremy/DCO.txt for more
details.

> ---
>   package/Config.in                                |    1 +
>   package/liblog4c-localtime/Config.in             |    9 +++++++++
>   package/liblog4c-localtime/liblog4c-localtime.mk |   11 +++++++++++
>   3 files changed, 21 insertions(+), 0 deletions(-)
>   create mode 100644 package/liblog4c-localtime/Config.in
>   create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 8a7c9c4..25752e5 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
>   source "package/orc/Config.in"
>   source "package/poco/Config.in"
>   source "package/startup-notification/Config.in"
> +source "package/liblog4c-localtime/Config.in"
>   endmenu
>
>   menu "Text and terminal handling"
> diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
> new file mode 100644
> index 0000000..58797be
> --- /dev/null
> +++ b/package/liblog4c-localtime/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_LIBLOG4C
> +	bool "liblog4c-localtime"
> +	help
> +	  Log4c is a library of C for flexible logging to files, syslog
> +	  and other destinations.
> +	  This version is with localtime patch, to make lib show times in
> +	  local timezone.
> +
> +	  https://github.com/rcmadruga/log4c-localtime

  Add the upstream URL as well: http://log4c.sourceforge.net/

> diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
> new file mode 100644
> index 0000000..f0599c3
> --- /dev/null
> +++ b/package/liblog4c-localtime/liblog4c-localtime.mk
> @@ -0,0 +1,11 @@
> + #############################################################
> + #
> + # liblog4c
> + #
> + #############################################################
> + LIBLOG4C_VERSION = 1.2.1
> + LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git

  There's also a tarball:
LIBLOG4C_LOCALTIME_VERSION = v1.0
LIBLOG4C_LOCALTIME_SITE    = https://github.com/rcmadruga/log4c-localtime/tarball/v$(LIBLOG4C_LOCALTIME_VERSION)

> + LIBLOG4C_INSTALL_STAGING = YES
> +
> + $(eval $(call AUTOTARGETS))
> +

  Spurious newline at the end.


  It looks like it requires expat, so you need "select BR2_PACKAGE_EXPAT"
to Config.in, and "LIBLOG4C_LOCALTIME_DEPENDENCIES = expat" in .mk.  You'll
probably also need --disable-expattest for cross-compilation.


  Regards,
  Arnout

Patch

diff --git a/package/Config.in b/package/Config.in
index 8a7c9c4..25752e5 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -387,6 +387,7 @@  source "package/lttng-libust/Config.in"
 source "package/orc/Config.in"
 source "package/poco/Config.in"
 source "package/startup-notification/Config.in"
+source "package/liblog4c-localtime/Config.in"
 endmenu
 
 menu "Text and terminal handling"
diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
new file mode 100644
index 0000000..58797be
--- /dev/null
+++ b/package/liblog4c-localtime/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_LIBLOG4C
+	bool "liblog4c-localtime"
+	help
+	  Log4c is a library of C for flexible logging to files, syslog 
+	  and other destinations.
+	  This version is with localtime patch, to make lib show times in
+	  local timezone.
+
+	  https://github.com/rcmadruga/log4c-localtime
diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
new file mode 100644
index 0000000..f0599c3
--- /dev/null
+++ b/package/liblog4c-localtime/liblog4c-localtime.mk
@@ -0,0 +1,11 @@ 
+ #############################################################
+ #
+ # liblog4c
+ #
+ #############################################################
+ LIBLOG4C_VERSION = 1.2.1
+ LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git
+ LIBLOG4C_INSTALL_STAGING = YES 
+
+ $(eval $(call AUTOTARGETS))
+