Message ID | 20121003.205053.1711360628623711137.davem@davemloft.net |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Hi David, On Wed, 03 Oct 2012 20:50:53 -0400 (EDT) David Miller <davem@davemloft.net> wrote: > > I do have a question though, it is honestly really that much easier to > revert a whole days worth of changes (and therefore not get the code > tested at all) than to simply add the obvious one liner? Actually, for me it is. I have a script that does the "use yesterday's version" for me. To fix (even a one liner) means bringing up an editor, commiting, creating the patch and then recommiting it (an implementation detail) and recording that I need to keep (automatically) applying the patch in case the maintainer doesn't react quickly. In this particular case I have been telling people to include vmalloc.h (and other things like slab.h) over and over for years ... its a pain that x86 builds indirectly include so much stuff. > It seems to me to be absolutely the wrong tradeoff in these situations. I guess for the "current/fixes" tree during the merge window, you are right. For the "normal" trees, does a delay of (usually) one day really matter? I used to fix all this stuff and it added considerably to the length of my work day (which currently can be up to 16 hours long) :-(
From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Thu, 4 Oct 2012 11:06:15 +1000 > Actually, for me it is. I have a script that does the "use yesterday's > version" for me. To fix (even a one liner) means bringing up an editor, > commiting, creating the patch and then recommiting it (an implementation > detail) and recording that I need to keep (automatically) applying the > patch in case the maintainer doesn't react quickly. Ok, fair enough. I'll try to look into making x86 barf when a vmalloc.h include is missing. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David and Stephen, I apologize for not taking the necessary steps to verify our patches before submission. Ignorance is not an excuse... Anyways David thank you for fixing the issue for us. Jay- -----Original Message----- From: David Miller [mailto:davem@davemloft.net] Sent: Wednesday, October 03, 2012 6:48 PM To: sfr@canb.auug.org.au Cc: netdev@vger.kernel.org; linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Vipul Pandya; Jay Hernandez Subject: Re: linux-next: build failure after merge of the net tree From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Thu, 4 Oct 2012 11:06:15 +1000 > Actually, for me it is. I have a script that does the "use > yesterday's version" for me. To fix (even a one liner) means bringing > up an editor, commiting, creating the patch and then recommiting it > (an implementation > detail) and recording that I need to keep (automatically) applying the > patch in case the maintainer doesn't react quickly. Ok, fair enough. I'll try to look into making x86 barf when a vmalloc.h include is missing. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
==================== [PATCH] cxgb4: Fix build error due to missing linux/vmalloc.h include. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h index 745a1f5..31752b2 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4.h @@ -43,6 +43,7 @@ #include <linux/pci.h> #include <linux/spinlock.h> #include <linux/timer.h> +#include <linux/vmalloc.h> #include <asm/io.h> #include "cxgb4_uld.h" #include "t4_hw.h"