Patchwork [v2,3/4] zynq_slcr: Fixed ResetValues enum

login
register
mail settings
Submitter Peter A. G. Crosthwaite
Date Oct. 4, 2012, 12:16 a.m.
Message ID <e808709e73eb037df426f639667bb978c90fc31a.1349308835.git.peter.crosthwaite@xilinx.com>
Download mbox | patch
Permalink /patch/188967/
State New
Headers show

Comments

Peter A. G. Crosthwaite - Oct. 4, 2012, 12:16 a.m.
From: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>

There is a gap in the reset region of the address space at offset 0x208. This
throws out all these enum values by one when translating them to address offsets.
Fixed by putting the corresponding gap in the enum as well.

Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
---

 hw/zynq_slcr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Peter Maydell - Oct. 9, 2012, 11:53 a.m.
On 4 October 2012 01:16, Peter Crosthwaite
<peter.crosthwaite@petalogix.com> wrote:
> From: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
>
> There is a gap in the reset region of the address space at offset 0x208. This
> throws out all these enum values by one when translating them to address offsets.
> Fixed by putting the corresponding gap in the enum as well.
>
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>

This fix isn't dependent on the rest of this patchset, right? I can put
it in arm-devs.next now if you like or you could send it via -trivial.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM
Peter A. G. Crosthwaite - Oct. 9, 2012, 1:16 p.m.
Yes it is independent.

Please queue to arm-devs,

Regards,
Peter

On Tue, Oct 9, 2012 at 9:53 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 4 October 2012 01:16, Peter Crosthwaite
> <peter.crosthwaite@petalogix.com> wrote:
>> From: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
>>
>> There is a gap in the reset region of the address space at offset 0x208. This
>> throws out all these enum values by one when translating them to address offsets.
>> Fixed by putting the corresponding gap in the enum as well.
>>
>> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
>
> This fix isn't dependent on the rest of this patchset, right? I can put
> it in arm-devs.next now if you like or you could send it via -trivial.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> -- PMM

Patch

diff --git a/hw/zynq_slcr.c b/hw/zynq_slcr.c
index 468fb0e..6eafad5 100644
--- a/hw/zynq_slcr.c
+++ b/hw/zynq_slcr.c
@@ -93,7 +93,7 @@  typedef enum {
 typedef enum {
   PSS,
   DDDR,
-  DMAC,
+  DMAC = 3,
   USB,
   GEM,
   SDIO,