diff mbox

[2.6.28] cxgb3 - Fix LRO misalignment

Message ID 20090116004829.7437.52798.stgit@speedy5
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Divy Le Ray Jan. 16, 2009, 12:48 a.m. UTC 
From: Divy Le Ray <divy@chelsio.com>

The lro manager's frag_align_pad setting was missing,
leading to misaligned access to the skb passed up
to the stack.

Signed-off-by: Divy Le Ray <divy@chelsio.com>
---

 drivers/net/cxgb3/sge.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rick Jones Jan. 16, 2009, 1:57 a.m. UTC | #1 
Divy Le Ray wrote:
> From: Divy Le Ray <divy@chelsio.com>
> 
> The lro manager's frag_align_pad setting was missing,
> leading to misaligned access to the skb passed up
> to the stack.
> 
> Signed-off-by: Divy Le Ray <divy@chelsio.com>

I have tried this in a tree I have, and where I was once seeing unaligned access 
messages on an ia64 system with LRO enabled, now I see none.

Tested-by: Rick Jones <rick.jones2@hp.com>

rick jones
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Divy Le Ray Jan. 16, 2009, 7:05 p.m. UTC | #2 
Rick Jones wrote:
> Divy Le Ray wrote:
>   
>> From: Divy Le Ray <divy@chelsio.com>
>>
>> The lro manager's frag_align_pad setting was missing,
>> leading to misaligned access to the skb passed up
>> to the stack.
>>
>> Signed-off-by: Divy Le Ray <divy@chelsio.com>
>>     
>
> I have tried this in a tree I have, and where I was once seeing unaligned access 
> messages on an ia64 system with LRO enabled, now I see none.
>
> Tested-by: Rick Jones <rick.jones2@hp.com>
>
> rick jones
>
>   
Hi Dave,

The patch is intended for 2.6.29, not 2.6.28 as the subject mistakenly 
states.

Cheers,
Divy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Jan. 19, 2009, 6:01 a.m. UTC | #3 
From: Divy Le Ray <divy@chelsio.com>
Date: Fri, 16 Jan 2009 11:05:50 -0800

> The patch is intended for 2.6.29, not 2.6.28 as the subject mistakenly states.

Understood, applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/cxgb3/sge.c b/drivers/net/cxgb3/sge.c
index 14f9fb3..379a132 100644
--- a/drivers/net/cxgb3/sge.c
+++ b/drivers/net/cxgb3/sge.c
@@ -2104,6 +2104,7 @@  static void init_lro_mgr(struct sge_qset *qs, struct net_lro_mgr *lro_mgr)
 {
 	lro_mgr->dev = qs->netdev;
 	lro_mgr->features = LRO_F_NAPI;
+	lro_mgr->frag_align_pad = NET_IP_ALIGN;
 	lro_mgr->ip_summed = CHECKSUM_UNNECESSARY;
 	lro_mgr->ip_summed_aggr = CHECKSUM_UNNECESSARY;
 	lro_mgr->max_desc = T3_MAX_LRO_SES;