Patchwork [RFC,18/18] pc: generate APIC IDs according to CPU topology (v3)

login
register
mail settings
Submitter Eduardo Habkost
Date Oct. 3, 2012, 1:29 p.m.
Message ID <1349270954-4657-19-git-send-email-ehabkost@redhat.com>
Download mbox | patch
Permalink /patch/188783/
State New
Headers show

Comments

Eduardo Habkost - Oct. 3, 2012, 1:29 p.m.
This keeps compatibility on machine-types pc-1.2 and older, and prints a
warning in case the requested configuration won't get the correct
topology.

At first I was going to use object_property_add() on PC instance_init
function, but this wouldn't allow us to use global properties to set
it[1]. So I had to use a static DEFINE_PROP_BIT for the
contiguous_apic_ids property.

[1] See my qdev question at:
    http://article.gmane.org/gmane.comp.emulators.qemu/173625

Changes v2 -> v3:
 - Now all code is inside hw/pc.c
 - Use a real "PC" class and a "contiguous_apic_ids" property

Changes v1 -> v2:
 - Move code to cpu.c
 - keep using cpu_index on *-user
 - Use SMP.contiguous_apic_ids global property
 - Prints warning in case the compatibility mode will expose incorrect
   topology

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/pc.c      | 45 ++++++++++++++++++++++++++++++++++++++++-----
 hw/pc_piix.c |  4 ++++
 2 files changed, 44 insertions(+), 5 deletions(-)

Patch

diff --git a/hw/pc.c b/hw/pc.c
index 4c9b2f6..c33768b 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -52,6 +52,8 @@ 
 #include "arch_init.h"
 #include "bitmap.h"
 #include "vga-pci.h"
+#include "topology.h"
+#include "cpus.h"
 
 /* debug PC/ISA interrupts */
 //#define DEBUG_IRQ
@@ -552,13 +554,34 @@  static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
 
 typedef struct PC {
     DeviceState parent_obj;
+
+    /* Compatibility mode that force APIC IDs to be contiguous
+     *
+     * Setting it to true may break some CPU topologies (e.g. if core or thread
+     * count is not a power of 2).
+     */
+#define PC_FLAG_CONTIGUOUS_APIC_IDS 0
+
+    uint32_t flags;
 } PC;
 
+static Property pc_properties[] = {
+    DEFINE_PROP_BIT("contiguous_apic_ids", PC, flags,
+                    PC_FLAG_CONTIGUOUS_APIC_IDS, false),
+    DEFINE_PROP_END_OF_LIST()
+};
+
+static void pc_class_init(ObjectClass *klass, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(klass);
+    dc->props = pc_properties;
+}
+
 static const TypeInfo pc_type_info = {
     .name = TYPE_PC_MACHINE,
     .parent = TYPE_DEVICE,
     .instance_size = sizeof(PC),
-    .class_size = sizeof(DeviceClass),
+    .class_init = pc_class_init,
 };
 
 static void pc_register_type(void)
@@ -576,10 +599,22 @@  type_init(pc_register_type);
  */
 static uint32_t apic_id_for_cpu(PC *pc, int cpu_index)
 {
-    /* right now APIC ID == CPU index. this will eventually change to use
-     * the CPU topology configuration properly
-     */
-    return cpu_index;
+    unsigned int correct_id;
+    static bool warned;
+    bool contig;
+
+    correct_id = topo_apicid_for_cpu(smp_cores, smp_threads, cpu_index);
+    contig = object_property_get_bool(OBJECT(pc), "contiguous_apic_ids", NULL);
+    if (contig) {
+        if (cpu_index != correct_id && !warned) {
+            fprintf(stderr, "warning: CPU topology in compat mode, "
+                            "results won't match the requested topology\n");
+            warned = true;
+        }
+        return cpu_index;
+    } else {
+        return correct_id;
+    }
 }
 
 int e820_add_entry(uint64_t address, uint64_t length, uint32_t type)
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index f861907..8a4a5f6 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -374,6 +374,10 @@  static QEMUMachine pc_machine_v1_3 = {
             .driver   = "ivshmem",\
             .property = "use64",\
             .value    = "0",\
+        },{\
+            .driver   = "PC",\
+            .property = "contiguous_apic_ids",\
+            .value    = "true",\
         }
 
 static QEMUMachine pc_machine_v1_2 = {