Patchwork s390: avoid reaching into memory core internals

login
register
mail settings
Submitter Avi Kivity
Date Oct. 3, 2012, 2:15 p.m.
Message ID <1349273708-29482-1-git-send-email-avi@redhat.com>
Download mbox | patch
Permalink /patch/188779/
State New
Headers show

Comments

Avi Kivity - Oct. 3, 2012, 2:15 p.m.
use cpu_physical_memory_is_io() instead.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 target-s390x/misc_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c
index e9b3cae..2da4c90 100644
--- a/target-s390x/misc_helper.c
+++ b/target-s390x/misc_helper.c
@@ -81,7 +81,7 @@  int sclp_service_call(CPUS390XState *env, uint32_t sccb, uint64_t code)
 #endif
 
     /* basic checks */
-    if (!memory_region_is_ram(phys_page_find(sccb >> TARGET_PAGE_BITS)->mr)) {
+    if (cpu_physical_memory_is_io(sccb)) {
         return -PGM_ADDRESSING;
     }
     if (sccb & ~0x7ffffff8ul) {