Patchwork [RFC,05/18] cpus.h: include qemu-stdio.h

login
register
mail settings
Submitter Eduardo Habkost
Date Oct. 3, 2012, 1:29 p.m.
Message ID <1349270954-4657-6-git-send-email-ehabkost@redhat.com>
Download mbox | patch
Permalink /patch/188774/
State New
Headers show

Comments

Eduardo Habkost - Oct. 3, 2012, 1:29 p.m.
Needed for the definition of fprint_function.

This is not necessary right now, but it will be necessary if code that
doesn't include cpu-common.h includes cpus.h.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 cpus.h | 2 ++
 1 file changed, 2 insertions(+)
Igor Mammedov - Oct. 4, 2012, noon
On Wed,  3 Oct 2012 10:29:01 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> Needed for the definition of fprint_function.
> 
> This is not necessary right now, but it will be necessary if code that
> doesn't include cpu-common.h includes cpus.h.
Could be it cut to a separate standard hearders, and include only that on
which it depends?

> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  cpus.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/cpus.h b/cpus.h
> index 81bd817..b7c3708 100644
> --- a/cpus.h
> +++ b/cpus.h
> @@ -1,6 +1,8 @@
>  #ifndef QEMU_CPUS_H
>  #define QEMU_CPUS_H
>  
> +#include "qemu-stdio.h"
> +
>  /* cpus.c */
>  void qemu_init_cpu_loop(void);
>  void resume_all_vcpus(void);
Eduardo Habkost - Oct. 4, 2012, 1:14 p.m.
On Thu, Oct 04, 2012 at 02:00:57PM +0200, Igor Mammedov wrote:
> On Wed,  3 Oct 2012 10:29:01 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
> 
> > Needed for the definition of fprint_function.
> > 
> > This is not necessary right now, but it will be necessary if code that
> > doesn't include cpu-common.h includes cpus.h.
> Could be it cut to a separate standard hearders, and include only that on
> which it depends?

Are you talking about cpus.h, or qemu-stdio.h?

qemu-stdio.h is a new header, and is very small. I don't see how we
could split it further.

cpus.h is tiny, too, I don't see why we would split it.

> 
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  cpus.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/cpus.h b/cpus.h
> > index 81bd817..b7c3708 100644
> > --- a/cpus.h
> > +++ b/cpus.h
> > @@ -1,6 +1,8 @@
> >  #ifndef QEMU_CPUS_H
> >  #define QEMU_CPUS_H
> >  
> > +#include "qemu-stdio.h"
> > +
> >  /* cpus.c */
> >  void qemu_init_cpu_loop(void);
> >  void resume_all_vcpus(void);
> 
>
Igor Mammedov - Oct. 4, 2012, 2:05 p.m.
On Thu, 4 Oct 2012 10:14:48 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> On Thu, Oct 04, 2012 at 02:00:57PM +0200, Igor Mammedov wrote:
> > On Wed,  3 Oct 2012 10:29:01 -0300
> > Eduardo Habkost <ehabkost@redhat.com> wrote:
> > 
> > > Needed for the definition of fprint_function.
> > > 
> > > This is not necessary right now, but it will be necessary if code that
> > > doesn't include cpu-common.h includes cpus.h.
> > Could be it cut to a separate standard hearders, and include only that on
> > which it depends?
> 
> Are you talking about cpus.h, or qemu-stdio.h?
Ah, never mind, I see it is included for fprint_function().

> 
> qemu-stdio.h is a new header, and is very small. I don't see how we
> could split it further.
> 
> cpus.h is tiny, too, I don't see why we would split it.
> 
> > 
> > > 
> > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > > ---
> > >  cpus.h | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/cpus.h b/cpus.h
> > > index 81bd817..b7c3708 100644
> > > --- a/cpus.h
> > > +++ b/cpus.h
> > > @@ -1,6 +1,8 @@
> > >  #ifndef QEMU_CPUS_H
> > >  #define QEMU_CPUS_H
> > >  
> > > +#include "qemu-stdio.h"
> > > +
> > >  /* cpus.c */
> > >  void qemu_init_cpu_loop(void);
> > >  void resume_all_vcpus(void);
> > 
> > 
>

Patch

diff --git a/cpus.h b/cpus.h
index 81bd817..b7c3708 100644
--- a/cpus.h
+++ b/cpus.h
@@ -1,6 +1,8 @@ 
 #ifndef QEMU_CPUS_H
 #define QEMU_CPUS_H
 
+#include "qemu-stdio.h"
+
 /* cpus.c */
 void qemu_init_cpu_loop(void);
 void resume_all_vcpus(void);