Message ID | 506BFF58.4060106@nod.at |
---|---|
State | New, archived |
Headers | show |
On Wed, 2012-10-03 at 11:03 +0200, Richard Weinberger wrote: > Yeah, it looks like all issues reported by aiaiai are caused by the missing goto. > Can you deal with the patch below or do you want me to send it using git send-email? I'll apply it. But please, re-work the error handling in that function separately.
On 03.10.2012 11:30, Artem Bityutskiy wrote: > On Wed, 2012-10-03 at 11:03 +0200, Richard Weinberger wrote: >> Yeah, it looks like all issues reported by aiaiai are caused by the missing goto. >> Can you deal with the patch below or do you want me to send it using git send-email? > > I'll apply it. But please, re-work the error handling in that function > separately. > Okay, but not now during the merge window. Is this fine for you? Thanks, //richard
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index be73a1d..adcb2e4 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -917,6 +917,7 @@ int ubi_scan_fastmap(struct ubi_device *ubi, struct ubi_attach_info *ai, ret = UBI_BAD_FASTMAP; kfree(fmsb); kfree(fm); + goto out; } ech = kzalloc(ubi->ec_hdr_alsize, GFP_KERNEL);