Patchwork rtc: Eleminate some warnings

login
register
mail settings
Submitter venu
Date Oct. 3, 2012, 5:28 a.m.
Message ID <1349242137.20140.YahooMailNeo@web192503.mail.sg3.yahoo.com>
Download mbox | patch
Permalink /patch/188710/
State New
Headers show

Comments

venu - Oct. 3, 2012, 5:28 a.m.
Would it not be good to have subject line as "rtc: m41t80: Eleminate some warnings",
to indicate the patch changes are specific to m41t80 RTC only. Without having RTC
part name in the subject, it appears that the changes are for generic RTC driver.

Patch

diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index 4e0f84a..484aaf8 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -213,6 +213,8 @@  static int m41t80_rtc_set_time(struct device *dev, struct rtc_time *tm)
    return m41t80_set_datetime(to_i2c_client(dev), tm);
}

+/* Alarm code is currently broken */
+#if 0
static int m41t80_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
{
    struct i2c_client *client = to_i2c_client(dev);
@@ -353,6 +355,7 @@  static int m41t80_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *t)
    t->pending = !!(reg[M41T80_REG_FLAGS] & M41T80_FLAGS_AF);
    return 0;
}
+#endif

static struct rtc_class_ops m41t80_rtc_ops = {
    .read_time = m41t80_rtc_read_time,