Patchwork [U-Boot] i2c: sh: Remove irq_wait function

login
register
mail settings
Submitter Nobuhiro Iwamatsu
Date Oct. 3, 2012, 2:49 a.m.
Message ID <1349232558-21988-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
Download mbox | patch
Permalink /patch/188698/
State Accepted
Delegated to: Albert ARIBAUD
Headers show

Comments

Nobuhiro Iwamatsu - Oct. 3, 2012, 2:49 a.m.
irq_wait function is not referred to from anywhere.

Reported-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>

---
 drivers/i2c/sh_i2c.c |   16 ----------------
 1 file changed, 16 deletions(-)
Heiko Schocher - Oct. 4, 2012, 6:25 a.m.
Hello Nobuhiro,

Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> wrote:
> irq_wait function is not referred to from anywhere.
>
> Reported-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>
> ---
>  drivers/i2c/sh_i2c.c |   16 ----------------
>  1 file changed, 16 deletions(-)

Good catch!

Hmm.. for some reason, I could not find this patch in patchwork...
Did you or Albert changed the state from it in patchwork?

bye,
Heiko
Anatolij Gustschin - Oct. 4, 2012, 7:41 a.m.
Hi Heiko,

On Thu, 04 Oct 2012 08:25:55 +0200
hs@denx.de wrote:

> Hello Nobuhiro,
> 
> Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> wrote:
> > irq_wait function is not referred to from anywhere.
> >
> > Reported-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> >
> > ---
> >  drivers/i2c/sh_i2c.c |   16 ----------------
> >  1 file changed, 16 deletions(-)
> 
> Good catch!
> 
> Hmm.. for some reason, I could not find this patch in patchwork...
> Did you or Albert changed the state from it in patchwork?

this patch is already in u-boot-arm.git tree and the state on patchwork
is accepted. Albert applied it directly, it seems.

Thanks,
Anatolij

Patch

diff --git a/drivers/i2c/sh_i2c.c b/drivers/i2c/sh_i2c.c
index fd8cb92..3147123 100644
--- a/drivers/i2c/sh_i2c.c
+++ b/drivers/i2c/sh_i2c.c
@@ -52,22 +52,6 @@  static u8 iccl, icch;
 
 #define IRQ_WAIT 1000
 
-static void irq_wait(struct sh_i2c *base)
-{
-	int i;
-	u8 status;
-
-	for (i = 0 ; i < IRQ_WAIT ; i++) {
-		status = readb(&base->icsr);
-		if (SH_IC_WAIT & status)
-			break;
-
-		udelay(10);
-	}
-
-	writeb(status & ~SH_IC_WAIT, &base->icsr);
-}
-
 static void irq_dte(struct sh_i2c *base)
 {
 	int i;