Patchwork rtc: Eleminate some warnings

login
register
mail settings
Submitter Tony Breeds
Date Oct. 3, 2012, 2:13 a.m.
Message ID <1349230407-7145-1-git-send-email-tony@bakeyournoodle.com>
Download mbox | patch
Permalink /patch/188695/
State New
Headers show

Comments

Tony Breeds - Oct. 3, 2012, 2:13 a.m.
Currently a compile issues:
drivers/rtc/rtc-m41t80.c:216: warning: 'm41t80_rtc_alarm_irq_enable' defined but not used
drivers/rtc/rtc-m41t80.c:238: warning: 'm41t80_rtc_set_alarm' defined but not used
drivers/rtc/rtc-m41t80.c:308: warning: 'm41t80_rtc_read_alarm' defined but not used

A comment in the code explains that thew alarm code is buggy and
commented out.  This patch just comments out the static functions to
complete that work.

Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
---
 drivers/rtc/rtc-m41t80.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Patch

diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index 4e0f84a..484aaf8 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -213,6 +213,8 @@  static int m41t80_rtc_set_time(struct device *dev, struct rtc_time *tm)
 	return m41t80_set_datetime(to_i2c_client(dev), tm);
 }
 
+/* Alarm code is currently broken */
+#if 0
 static int m41t80_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
 {
 	struct i2c_client *client = to_i2c_client(dev);
@@ -353,6 +355,7 @@  static int m41t80_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *t)
 	t->pending = !!(reg[M41T80_REG_FLAGS] & M41T80_FLAGS_AF);
 	return 0;
 }
+#endif
 
 static struct rtc_class_ops m41t80_rtc_ops = {
 	.read_time = m41t80_rtc_read_time,